From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5E2C282C4 for ; Tue, 12 Feb 2019 17:00:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32F38217FA for ; Tue, 12 Feb 2019 17:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731185AbfBLRA0 (ORCPT ); Tue, 12 Feb 2019 12:00:26 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:55475 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728927AbfBLRAZ (ORCPT ); Tue, 12 Feb 2019 12:00:25 -0500 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Tue, 12 Feb 2019 18:00:23 +0100 Received: from suse.de (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Tue, 12 Feb 2019 17:00:10 +0000 Date: Tue, 12 Feb 2019 20:00:59 +0100 From: Mian Yousaf Kaukab To: Peng Ma Cc: axboe@kernel.dk, shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andy.tang@nxp.com Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support Message-ID: <20190212190059.GA9272@suse.de> References: <20190125081013.21663-1-peng.ma@nxp.com> <20190125081013.21663-2-peng.ma@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190125081013.21663-2-peng.ma@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 25, 2019 at 08:10:13AM +0000, Peng Ma wrote: > Add SATA device nodes for fsl-lx2160a and enable support > for QDS and RDB boards. > > Signed-off-by: Peng Ma > --- > changed for V5: > - no change > > arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 16 +++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 16 +++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 44 +++++++++++++++++++++ > 3 files changed, 76 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > index 99a22ab..1a5acf6 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > @@ -95,6 +95,22 @@ > }; > }; > > +&sata0 { > + status = "okay"; > +}; > + > +&sata1 { > + status = "okay"; > +}; > + > +&sata2 { > + status = "okay"; > +}; > + > +&sata3 { > + status = "okay"; > +}; > + > &uart0 { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 6481e5f..5b6799e 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -102,6 +102,22 @@ > }; > }; > > +&sata0 { > + status = "okay"; > +}; > + > +&sata1 { > + status = "okay"; > +}; > + > +&sata2 { > + status = "okay"; > +}; > + > +&sata3 { > + status = "okay"; > +}; > + > &uart0 { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index a79f5c1..592034b 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -671,6 +671,50 @@ > status = "disabled"; > }; > > + sata0: sata@3200000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3200000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata1: sata@3210000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3210000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata2: sata@3220000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3220000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata3: sata@3230000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3230000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; You are using same reg values for sata-ecc in all sata instances. Does this actually work? No errors when the ahci_qoriq driver do ioremap on it while probing second instance and onward? fsl-ls208xa.dtsi is the only other file here with multiple sata instances and it doesn’t care about sata-ecc. > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > smmu: iommu@5000000 { > compatible = "arm,mmu-500"; > reg = <0 0x5000000 0 0x800000>; BR, Yousaf