From: kbuild test robot <lkp@intel.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: kbuild-all@01.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] elf: use list_for_each_entry()
Date: Tue, 12 Feb 2019 23:49:51 +0800 [thread overview]
Message-ID: <201902122314.5Z57Au0r%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190204202800.GB27482@avx2>
[-- Attachment #1: Type: text/plain, Size: 2839 bytes --]
Hi Alexey,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc4]
[cannot apply to next-20190212]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Alexey-Dobriyan/elf-don-t-be-afraid-of-overflow/20190205-225931
config: nds32-defconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 6.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=6.4.0 make.cross ARCH=nds32
All errors (new ones prefixed by >>):
fs/binfmt_elf.c: In function 'write_note_info':
>> fs/binfmt_elf.c:2124:19: error: 'tmp' undeclared (first use in this function)
for (i = 0; i < tmp->num_notes; i++)
^~~
fs/binfmt_elf.c:2124:19: note: each undeclared identifier is reported only once for each function it appears in
vim +/tmp +2124 fs/binfmt_elf.c
3aba481f Roland McGrath 2008-01-30 2111
3aba481f Roland McGrath 2008-01-30 2112 static int write_note_info(struct elf_note_info *info,
ecc8c772 Al Viro 2013-10-05 2113 struct coredump_params *cprm)
3aba481f Roland McGrath 2008-01-30 2114 {
1e0d184d Alexey Dobriyan 2019-02-04 2115 struct elf_thread_status *ets;
3aba481f Roland McGrath 2008-01-30 2116 int i;
3aba481f Roland McGrath 2008-01-30 2117
3aba481f Roland McGrath 2008-01-30 2118 for (i = 0; i < info->numnote; i++)
ecc8c772 Al Viro 2013-10-05 2119 if (!writenote(info->notes + i, cprm))
3aba481f Roland McGrath 2008-01-30 2120 return 0;
3aba481f Roland McGrath 2008-01-30 2121
3aba481f Roland McGrath 2008-01-30 2122 /* write out the thread status notes section */
1e0d184d Alexey Dobriyan 2019-02-04 2123 list_for_each_entry(ets, &info->thread_list, list) {
3aba481f Roland McGrath 2008-01-30 @2124 for (i = 0; i < tmp->num_notes; i++)
ecc8c772 Al Viro 2013-10-05 2125 if (!writenote(&tmp->notes[i], cprm))
3aba481f Roland McGrath 2008-01-30 2126 return 0;
3aba481f Roland McGrath 2008-01-30 2127 }
3aba481f Roland McGrath 2008-01-30 2128
3aba481f Roland McGrath 2008-01-30 2129 return 1;
3aba481f Roland McGrath 2008-01-30 2130 }
3aba481f Roland McGrath 2008-01-30 2131
:::::: The code at line 2124 was first introduced by commit
:::::: 3aba481fc94d83ff630d4b7cd2f7447010c4c6df elf core dump: notes reorg
:::::: TO: Roland McGrath <roland@redhat.com>
:::::: CC: Ingo Molnar <mingo@elte.hu>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 9712 bytes --]
next prev parent reply other threads:[~2019-02-12 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 20:27 [PATCH 1/4] elf: don't be afraid of overflow Alexey Dobriyan
2019-02-04 20:28 ` [PATCH 2/4] elf: use list_for_each_entry() Alexey Dobriyan
2019-02-04 20:28 ` [PATCH 3/4] elf: spread const a little Alexey Dobriyan
2019-02-04 20:33 ` [PATCH 4/4] elf: save allocation per exec Alexey Dobriyan
2019-02-12 15:49 ` kbuild test robot [this message]
2019-02-12 16:21 ` [PATCH 2/4] elf: use list_for_each_entry() kbuild test robot
2019-03-11 11:04 ` [PATCH 1/4] elf: don't be afraid of overflow Pavel Machek
2019-03-11 17:10 ` Alexey Dobriyan
2019-03-12 9:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201902122314.5Z57Au0r%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).