Re: [PATCH v5 1/6] RISC-V: Move free_initrd_mem() to kernel/setup.c

[Mike Rapoport <rppt@linux.ibm.com>]

On Wed, Feb 13, 2019 at 08:07:17AM +0000, Anup Patel wrote:
> We move free_initrd_mem() to kernel/setup.c so that all initrd related
> functions are in one place.

A few patches after you move setup_bootmem() that calls setup_initrd() to
mm/init.c. I'd say it makes more sense to move setup_intird() to
mm/init.c.
 
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
> ---
>  arch/riscv/kernel/setup.c | 4 ++++
>  arch/riscv/mm/init.c      | 7 -------
>  2 files changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 77564310235f..36f60b4d2147 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -96,6 +96,10 @@ static void __init setup_initrd(void)
>  	initrd_start = 0;
>  	initrd_end = 0;
>  }
> +
> +void free_initrd_mem(unsigned long start, unsigned long end)
> +{
> +}
>  #endif /* CONFIG_BLK_DEV_INITRD */
>  
>  pgd_t swapper_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 658ebf645f42..504a5e491f5a 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -14,7 +14,6 @@
>  #include <linux/init.h>
>  #include <linux/mm.h>
>  #include <linux/memblock.h>
> -#include <linux/initrd.h>
>  #include <linux/swap.h>
>  #include <linux/sizes.h>
>  
> @@ -64,9 +63,3 @@ void free_initmem(void)
>  {
>  	free_initmem_default(0);
>  }
> -
> -#ifdef CONFIG_BLK_DEV_INITRD
> -void free_initrd_mem(unsigned long start, unsigned long end)
> -{
> -}
> -#endif /* CONFIG_BLK_DEV_INITRD */
> -- 
> 2.17.1
> 

-- 
Sincerely yours,
Mike.