From: Mark Rutland <mark.rutland@arm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"yaojun8558363@gmail.com" <yaojun8558363@gmail.com>,
"cpandya@codeaurora.org" <cpandya@codeaurora.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"van.freenix@gmail.com" <van.freenix@gmail.com>
Subject: Re: [PATCH 2/3] arm64: mmu: early_pgtable_alloc: remove unnecessary comments
Date: Wed, 13 Feb 2019 11:21:36 +0000 [thread overview]
Message-ID: <20190213112136.GB22119@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190213094831.7292-2-peng.fan@nxp.com>
On Wed, Feb 13, 2019 at 09:37:29AM +0000, Peng Fan wrote:
> The empty zero page has been moved to bss area by
> commit 5227cfa71f9e ("arm64: mm: place empty_zero_page in bss"),
> and it alreay added "dsb ishst" in head.S to make sure the empty
> zero page visible to PTW.
>
> There is no code to reflect the comment, so remove it.
The comment below refers to the memory pointed to by ptr, which is
zeroed by the memset. The comment does not refer to the generic
empty_zero_page.
This comment is correct, and should stay. Please drop this patch.
Thanks,
Mark.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/mm/mmu.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index 065202da3ad2..f61fa7c8fd2e 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -113,10 +113,6 @@ static phys_addr_t __init early_pgtable_alloc(void)
>
> memset(ptr, 0, PAGE_SIZE);
>
> - /*
> - * Implicit barriers also ensure the zeroed page is visible to the page
> - * table walker
> - */
> pte_clear_fixmap();
>
> return phys;
> --
> 2.16.4
>
next prev parent reply other threads:[~2019-02-13 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:37 [PATCH 1/3] arm64: mmu: update paging_init comments Peng Fan
2019-02-13 9:37 ` [PATCH 2/3] arm64: mmu: early_pgtable_alloc: remove unnecessary comments Peng Fan
2019-02-13 11:21 ` Mark Rutland [this message]
2019-02-13 11:50 ` Peng Fan
2019-02-13 9:37 ` [PATCH 3/3] arm64: mmu: pgd_pgtable_alloc: drop barrier Peng Fan
2019-02-13 11:30 ` Mark Rutland
2019-02-13 11:54 ` Peng Fan
2019-02-13 11:18 ` [PATCH 1/3] arm64: mmu: update paging_init comments Mark Rutland
2019-02-13 11:49 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213112136.GB22119@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robin.murphy@arm.com \
--cc=van.freenix@gmail.com \
--cc=will.deacon@arm.com \
--cc=yaojun8558363@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).