From: Petr Mladek <pmladek@suse.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
tglx@linutronix.de, Julia Cartwright <julia@ni.com>,
Guenter Roeck <linux@roeck-us.net>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Tim Sander <tim@krieglstein.org>
Subject: Re: [PATCH 1/2] kthread: convert worker lock to raw spinlock
Date: Wed, 13 Feb 2019 13:13:01 +0100 [thread overview]
Message-ID: <20190213121301.d6sff2thya5eubwl@pathway.suse.cz> (raw)
In-Reply-To: <20190212162554.19779-1-bigeasy@linutronix.de>
On Tue 2019-02-12 17:25:53, Sebastian Andrzej Siewior wrote:
> From: Julia Cartwright <julia@ni.com>
>
> In order to enable the queuing of kthread work items from hardirq
> context even when PREEMPT_RT_FULL is enabled, convert the worker
> spin_lock to a raw_spin_lock.
>
> This is only acceptable to do because the work performed under the lock
> is well-bounded and minimal.
I could confirm that it is well-bounded and minimal. The most
expensive function probably is add_timer() called from
__kthread_queue_delayed_work(). It might spin a bit
to get timer->base->lock.
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Reported-and-tested-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Reported-by: Tim Sander <tim@krieglstein.org>
> Signed-off-by: Julia Cartwright <julia@ni.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2019-02-13 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 16:25 [PATCH 1/2] kthread: convert worker lock to raw spinlock Sebastian Andrzej Siewior
2019-02-12 16:25 ` [PATCH 2/2] kthread: Do not use TIMER_IRQSAFE Sebastian Andrzej Siewior
2019-02-13 12:02 ` Petr Mladek
2019-02-28 10:22 ` [tip:sched/core] " tip-bot for Sebastian Andrzej Siewior
2019-02-13 12:13 ` Petr Mladek [this message]
2019-02-28 10:22 ` [tip:sched/core] kthread: Convert worker lock to raw spinlock tip-bot for Julia Cartwright
-- strict thread matches above, loose matches on Subject: below --
2018-09-28 21:03 [PATCH 0/2] Fix watchdogd wakeup deferral on RT Julia Cartwright
2018-09-28 21:03 ` [PATCH 1/2] kthread: convert worker lock to raw spinlock Julia Cartwright
2018-10-05 16:46 ` Sebastian Andrzej Siewior
2018-10-05 18:10 ` Andrea Parri
2018-10-09 10:56 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213121301.d6sff2thya5eubwl@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=bigeasy@linutronix.de \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=tim@krieglstein.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).