From: Will Deacon <will.deacon@arm.com>
To: "Zhang, Lei" <zhang.lei@jp.fujitsu.com>
Cc: 'Mark Rutland' <mark.rutland@arm.com>,
'Catalin Marinas' <catalin.marinas@arm.com>,
'James Morse' <james.morse@arm.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 0/1] arm64: Add workaround for Fujitsu A64FX erratum 010001
Date: Wed, 13 Feb 2019 13:19:06 +0000 [thread overview]
Message-ID: <20190213131906.GB5875@brain-police> (raw)
In-Reply-To: <8898674D84E3B24BA3A2D289B872026A6A30C3CB@G01JPEXMBKW03>
On Tue, Feb 05, 2019 at 01:32:07PM +0000, Zhang, Lei wrote:
> > -----Original Message-----
> > From: linux-arm-kernel
> > [mailto:linux-arm-kernel-bounces@lists.infradead.org] On Behalf Of
> > Will Deacon
> > Sent: Friday, February 01, 2019 7:52 PM
> > To: Zhang, Lei
> > Cc: 'Mark Rutland'; 'Catalin Marinas'; 'James Morse';
> > 'linux-kernel@vger.kernel.org';
> > 'linux-arm-kernel@lists.infradead.org'
> > Subject: Re: [PATCH v3 0/1] arm64: Add workaround for Fujitsu A64FX
> > erratum 010001
>
> > So I guess we should boot with NFD1 clear, and then set it only when we
> > realise we're not on an A64FX?
>
> In my patch, I do similar things at __cpu_setup which we
> set NFD1=1 on all processors except A64FX.
>
> Do you mean we would better to change the place where we
> set/clear NFD1?
Yes, I think we should keep the code as simple as we can:
- Don't set NFDx=1 in proc.S for any CPU
- Later, in C code, we can set the bit for any CPU that is not an affected
A64FX (this can be a simple MIDR check).
Does that work?
Will
prev parent reply other threads:[~2019-02-13 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 12:29 [PATCH v3 0/1] arm64: Add workaround for Fujitsu A64FX erratum 010001 Zhang, Lei
2019-01-29 18:10 ` Catalin Marinas
2019-01-30 14:56 ` James Morse
2019-02-05 12:49 ` Zhang, Lei
2019-01-30 15:00 ` James Morse
2019-02-01 5:53 ` Zhang, Lei
2019-02-01 10:51 ` Will Deacon
2019-02-05 13:32 ` Zhang, Lei
2019-02-13 13:19 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213131906.GB5875@brain-police \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).