From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB979C282C2 for ; Wed, 13 Feb 2019 19:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FBEA222CF for ; Wed, 13 Feb 2019 19:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394487AbfBMTf1 (ORCPT ); Wed, 13 Feb 2019 14:35:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:42122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727484AbfBMTf0 (ORCPT ); Wed, 13 Feb 2019 14:35:26 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2333F2146E; Wed, 13 Feb 2019 19:35:25 +0000 (UTC) Date: Wed, 13 Feb 2019 14:35:23 -0500 From: Steven Rostedt To: Tom Zanussi Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel@joelfernandes.org, mathieu.desnoyers@efficios.com, julia@ni.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH v14 06/15] tracing: Add hist trigger snapshot() action Message-ID: <20190213143523.1e387566@gandalf.local.home> In-Reply-To: <20190213142551.0b89604e@gandalf.local.home> References: <20190213142551.0b89604e@gandalf.local.home> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Feb 2019 14:25:51 -0500 Steven Rostedt wrote: > > I noticed this because we hardcode the size in memcpy. Should hard code > it above, otherwise it looks like elt_data->comm may be something other > than TASK_COMM_LEN. Hi Tom, My comments on patch 5 and 6 are the only comments I have on the series. Could you address them and post a v15, and I'll pull them in and start testing them? Thanks! -- Steve