From: Yauhen Kharuzhy <jekhor@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-kernel@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 1/2] extcon-intel-cht-wc: Make charger detection co-existed with OTG host mode
Date: Thu, 14 Feb 2019 10:09:43 +0300 [thread overview]
Message-ID: <20190214070943.GB16597@jeknote.loshitsa1.net> (raw)
In-Reply-To: <767c3d5e-f521-4d59-3922-a322b4124126@redhat.com>
On Thu, Feb 14, 2019 at 12:15:00AM +0100, Hans de Goede wrote:
> Hi,
>
> On 10-02-19 21:36, Yauhen Kharuzhy wrote:
> > Whiskey Cove Cherry Trail PMIC requires disabling OTG host mode before
> > of charger detection procedure. Do this by manipulationg of CHGRCTRL1
> > register.
> >
> > Source: APCI DSDT code of Lenovo Yoga Book YB1-X91L and open-sourced
> > Intel's drivers.
>
> Hmm, of the ACPI code is updating the otg-mode, then there should be
> no reason for us to do this, can you provide an acpidump of your
> device please?
sure: https://github.com/jekhor/yogabook-linux/blob/master/yoga/acpi/yoga.acpidump.log
Yes, there is ACPI routine for switching this but it is not called at
IRQ handling because it is handled by extcon driver. See my notes here:
https://github.com/jekhor/yogabook-linux/blob/master/yoga/acpi/investigate.txt#L364
--
Yauhen Kharuzhy
next prev parent reply other threads:[~2019-02-14 7:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190210204024epcas3p36ea277b499e647b870d538c5680309bd@epcas3p3.samsung.com>
2019-02-10 20:36 ` [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks Yauhen Kharuzhy
2019-02-10 20:36 ` [PATCH 1/2] extcon-intel-cht-wc: Make charger detection co-existed with OTG host mode Yauhen Kharuzhy
2019-02-13 23:15 ` Hans de Goede
2019-02-14 7:09 ` Yauhen Kharuzhy [this message]
2019-02-14 15:32 ` Hans de Goede
2019-02-14 14:22 ` Hans de Goede
2019-02-10 20:36 ` [PATCH 2/2] extcon intel-cht-wc: Enable external charger Yauhen Kharuzhy
2019-02-14 16:31 ` Hans de Goede
2019-02-15 6:32 ` Yauhen Kharuzhy
2019-02-17 21:52 ` Yauhen Kharuzhy
2019-02-18 9:24 ` Hans de Goede
2019-02-18 15:07 ` Yauhen Kharuzhy
2019-02-19 13:39 ` Hans de Goede
2019-02-19 20:20 ` Yauhen Kharuzhy
2019-02-20 16:42 ` Hans de Goede
2019-02-20 20:28 ` Yauhen Kharuzhy
2019-02-21 9:33 ` Hans de Goede
2019-02-13 23:00 ` [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks Hans de Goede
2019-02-14 10:07 ` Hans de Goede
2019-02-14 12:47 ` Andy Shevchenko
[not found] ` <CAKWEGV7SGDMttB6uHwnkyjWk+bmSmZ-vTSOXHg1UAgLBeqnaXw@mail.gmail.com>
2019-02-14 15:05 ` Hans de Goede
2019-02-15 7:01 ` Yauhen Kharuzhy
2019-02-15 9:26 ` Hans de Goede
2019-02-15 9:29 ` Andy Shevchenko
2019-02-15 9:33 ` Hans de Goede
2019-02-15 7:08 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214070943.GB16597@jeknote.loshitsa1.net \
--to=jekhor@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).