linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Quentin Perret <quentin.perret@arm.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
	joelaf@google.com, smuckle@google.com, dietmar.eggemann@arm.com
Subject: Re: [PATCH v2] tracing: Fix number of entries in trace header
Date: Thu, 14 Feb 2019 11:28:18 -0500	[thread overview]
Message-ID: <20190214112818.701347c4@gandalf.local.home> (raw)
In-Reply-To: <20190214152950.4179-1-quentin.perret@arm.com>

On Thu, 14 Feb 2019 15:29:50 +0000
Quentin Perret <quentin.perret@arm.com> wrote:

> The following commit
> 
>   441dae8f2f29 ("tracing: Add support for display of tgid in trace output")

Thanks, I'll take a look at this.

> 
> removed the call to print_event_info() from print_func_help_header_irq()
> which results in the ftrace header not reporting the number of entries
> written in the buffer. As this wasn't the original intent of the patch,
> re-introduce the call to print_event_info() to restore the orginal
> behaviour.
> 
> Fixes: 441dae8f2f29 ("tracing: Add support for display of tgid in trace output")
> Cc: 4.13+ <stable@vger.kernel.org> # v4.13+

Note, with the "Fixes:" tag, adding the version number is obsolete. Just

Cc: stable@vger.kernel.org

is sufficient.

-- Steve

> Signed-off-by: Quentin Perret <quentin.perret@arm.com>
> Acked-by: Joel Fernandes <joelaf@google.com>
> ---
>  kernel/trace/trace.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index c521b7347482..c4238b441624 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -3384,6 +3384,8 @@ static void print_func_help_header_irq(struct trace_buffer *buf, struct seq_file
>  	const char tgid_space[] = "          ";
>  	const char space[] = "  ";
>  
> +	print_event_info(buf, m);
> +
>  	seq_printf(m, "#                          %s  _-----=> irqs-off\n",
>  		   tgid ? tgid_space : space);
>  	seq_printf(m, "#                          %s / _----=> need-resched\n",


      reply	other threads:[~2019-02-14 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 15:01 [PATCH] tracing: Fix number of entries in trace header Quentin Perret
2019-02-14 15:12 ` Joel Fernandes
2019-02-14 15:16   ` Quentin Perret
2019-02-14 15:29 ` [PATCH v2] " Quentin Perret
2019-02-14 16:28   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214112818.701347c4@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=joelaf@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=quentin.perret@arm.com \
    --cc=smuckle@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).