From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581F3C43381 for ; Thu, 14 Feb 2019 12:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C443218FF for ; Thu, 14 Feb 2019 12:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394381AbfBNMpP (ORCPT ); Thu, 14 Feb 2019 07:45:15 -0500 Received: from mga14.intel.com ([192.55.52.115]:21865 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387556AbfBNMpO (ORCPT ); Thu, 14 Feb 2019 07:45:14 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2019 04:45:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,368,1544515200"; d="scan'208";a="124449487" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga008.fm.intel.com with ESMTP; 14 Feb 2019 04:45:11 -0800 Received: from andy by smile with local (Exim 4.92-RC6) (envelope-from ) id 1guGO5-0003FZ-Ue; Thu, 14 Feb 2019 14:45:09 +0200 Date: Thu, 14 Feb 2019 14:45:09 +0200 From: Andy Shevchenko To: Petr Mladek Cc: Rasmus Villemoes , Linus Torvalds , "Tobin C . Harding" , Joe Perches , Andrew Morton , Michal Hocko , Sergey Senozhatsky , Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 9/9] vsprintf: Avoid confusion between invalid address and value Message-ID: <20190214124509.GS9224@smile.fi.intel.com> References: <20190208152310.29531-1-pmladek@suse.com> <20190208152310.29531-10-pmladek@suse.com> <20190208172717.GW9224@smile.fi.intel.com> <20190212154530.wjikbevy5beg2uzc@pathway.suse.cz> <20190213135455.GL9224@smile.fi.intel.com> <20190214084256.c26jd2b7oow3eatt@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190214084256.c26jd2b7oow3eatt@pathway.suse.cz> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 09:42:56AM +0100, Petr Mladek wrote: > On Wed 2019-02-13 15:54:55, Andy Shevchenko wrote: > > On Tue, Feb 12, 2019 at 04:45:30PM +0100, Petr Mladek wrote: > > > On Fri 2019-02-08 19:27:17, Andy Shevchenko wrote: > > > > On Fri, Feb 08, 2019 at 04:23:10PM +0100, Petr Mladek wrote: > > > > > We are able to detect invalid values handled by %p[iI] printk specifier. > > > > > The current error message is "invalid address". It might cause confusion > > > > > against "(efault)" reported by the generic valid_pointer_address() check. > > > > > > > > > > Let's unify the style and use the more appropriate error code description > > > > > "(einval)". > > > > > > > > The proper one should be "invalid address family". The proposed change > > > > increases confusion. > > > > > > I am confused. Is there any error code for "invalid address family"? > > > > I'm not sure. > > There is EAFNOSUPPORT. I don't know if it suits better. > > I would not complicate it. EAFNOSUPPORT looks too special, > see below. Also it is controversial here because vsprintf() > does not implement any protocol. > > > > > EINVAL is standard error code used when a wrong value is passed > > > as a parameter. In this case, the code is not able to handle > > > the given address family. > > > > This is possible, but it will produce more generic message. > > I am not sure that I understand it. We do not pass the error code > anywhere. The patch only changes the string that is shown instead > of the requested value. It is a hint that something is wrong > either with the caller or with the vsprintf() implementation. > > I think that it does not make sense to do a big deal from it. > "(einval)" looks informative enough to me. OK, let's go with it. -- With Best Regards, Andy Shevchenko