From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC649C43381 for ; Thu, 14 Feb 2019 12:46:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB0E0218FF for ; Thu, 14 Feb 2019 12:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406948AbfBNMqa (ORCPT ); Thu, 14 Feb 2019 07:46:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:60624 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727958AbfBNMqa (ORCPT ); Thu, 14 Feb 2019 07:46:30 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C0911AE3B; Thu, 14 Feb 2019 12:46:28 +0000 (UTC) Date: Thu, 14 Feb 2019 13:46:27 +0100 From: Petr Mladek To: Greg Kroah-Hartman Cc: John Ogness , linux-kernel@vger.kernel.org, Peter Zijlstra , Sergey Senozhatsky , Steven Rostedt , Daniel Wang , Andrew Morton , Linus Torvalds , Alan Cox , Jiri Slaby , Peter Feiner , linux-serial@vger.kernel.org, Sergey Senozhatsky Subject: Re: [RFC PATCH v1 03/25] printk-rb: define ring buffer struct and initializer Message-ID: <20190214124627.pmvsw3hsgvywmn32@pathway.suse.cz> References: <20190212143003.48446-1-john.ogness@linutronix.de> <20190212143003.48446-4-john.ogness@linutronix.de> <20190212144640.GB17291@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212144640.GB17291@kroah.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2019-02-12 15:46:40, Greg Kroah-Hartman wrote: > On Tue, Feb 12, 2019 at 03:29:41PM +0100, John Ogness wrote: > > See Documentation/printk-ringbuffer.txt for details about the > > initializer arguments. > > You can put that documentation here in the .h file and have it pulled > out automatically into the documentation files when they are created. > That way you always keep everything in sync properly. Yes, please, move the documentation into the sources. It is so easy to get the info via editor+cscope support than via an external text file that many people do not know about ;-) For example, see include/linux/livepatch.h for inspiration. Best Regards, Petr