From: Bjorn Helgaas <helgaas@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lukas Wunner <lukas@wunner.de>,
Heiner Kallweit <hkallweit1@gmail.com>,
Sinan Kaya <okaya@codeaurora.org>,
Keith Busch <keith.busch@intel.com>,
Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] PCI: Fix runtime PME generation from D3hot
Date: Thu, 14 Feb 2019 15:26:19 -0600 [thread overview]
Message-ID: <20190214212619.GO96272@google.com> (raw)
In-Reply-To: <20190131170746.7604-1-mika.westerberg@linux.intel.com>
On Thu, Jan 31, 2019 at 08:07:44PM +0300, Mika Westerberg wrote:
> Hi all,
>
> Heiner reported [1] that runtime PME generation of his network card does
> not work after commit 0e157e528604 ("PCI/PME: Implement runtime PM
> callbacks") that landed in v4.20. Reverting the commit helps but it has
> another drawback, which I originally tried to solve with the commit, that
> the PCIe hierarchy wakes up immediately after being put into D3cold.
>
> This series of two patches tries to fix both issues so that PME wakes up
> from D3hot and that the hierarchy does not wake up immediately from D3cold.
>
> The previous version of the series can be found here:
>
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1892241.html
>
> Changes from the previous version:
>
> * Add tags from Heiner and Rafael
> * Update changelog to mention relevent PCIe spec sections
> * Add comment to pcie_disable_interrupt() explaining why and what is
> masked
>
> [1] https://www.spinics.net/lists/linux-pci/msg79051.html
>
> Mika Westerberg (2):
> Revert "PCI/PME: Implement runtime PM callbacks"
> PCI: pciehp: Disable Data Link Layer State Changed event on suspend
I tentatively applied these to pci/pm for v5.1.
I suspect these should be marked for stable (v4.20+)?
I don't think the bugzilla in the second patch is directly relevant to
that patch. I'd like to update the patch with a more relevant
bugzilla if you have or can open one?
> drivers/pci/hotplug/pciehp_hpc.c | 17 +++++++++++++++--
> drivers/pci/pcie/pme.c | 27 ---------------------------
> 2 files changed, 15 insertions(+), 29 deletions(-)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-02-14 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 17:07 [PATCH v2 0/2] PCI: Fix runtime PME generation from D3hot Mika Westerberg
2019-01-31 17:07 ` [PATCH v2 1/2] Revert "PCI/PME: Implement runtime PM callbacks" Mika Westerberg
2019-01-31 17:07 ` [PATCH v2 2/2] PCI: pciehp: Disable Data Link Layer State Changed event on suspend Mika Westerberg
2019-02-14 21:23 ` Bjorn Helgaas
2019-02-15 9:36 ` Mika Westerberg
2019-02-14 21:26 ` Bjorn Helgaas [this message]
2019-02-15 9:38 ` [PATCH v2 0/2] PCI: Fix runtime PME generation from D3hot Mika Westerberg
2019-02-15 20:20 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214212619.GO96272@google.com \
--to=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@codeaurora.org \
--cc=poza@codeaurora.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).