From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: stable@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Richard Weinberger <richard.weinberger@gmail.com>,
Samuel Dionne-Riel <samuel@dionne-riel.com>,
LKML <linux-kernel@vger.kernel.org>,
graham@grahamc.com, Oleg Nesterov <oleg@redhat.com>,
Kees Cook <keescook@chromium.org>, Michal Hocko <mhocko@suse.com>
Subject: Re: Userspace regression in LTS and stable kernels
Date: Fri, 15 Feb 2019 08:00:22 +0100 [thread overview]
Message-ID: <20190215070022.GD14473@kroah.com> (raw)
In-Reply-To: <20190214122027.c0df36282d65dc9979248117@linux-foundation.org>
On Thu, Feb 14, 2019 at 12:20:27PM -0800, Andrew Morton wrote:
> On Thu, 14 Feb 2019 09:56:46 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > On Wed, Feb 13, 2019 at 3:37 PM Richard Weinberger
> > <richard.weinberger@gmail.com> wrote:
> > >
> > > Your shebang line exceeds BINPRM_BUF_SIZE.
> > > Before the said commit the kernel silently truncated the shebang line
> > > (and corrupted it),
> > > now it tells the user that the line is too long.
> >
> > It doesn't matter if it "corrupted" things by truncating it. All that
> > matters is "it used to work, now it doesn't"
> >
> > Yes, maybe it never *should* have worked. And yes, it's sad that
> > people apparently had cases that depended on this odd behavior, but
> > there we are.
> >
> > I see that Kees has a patch to fix it up.
> >
>
> Greg, I think we have a problem here.
>
> 8099b047ecc431518 ("exec: load_script: don't blindly truncate shebang
> string") wasn't marked for backporting. And, presumably as a
> consequence, Kees's fix "exec: load_script: allow interpreter argument
> truncation" was not marked for backporting.
>
> 8099b047ecc431518 hasn't even appeared in a Linus released kernel, yet
> it is now present in 4.9.x, 4.14.x, 4.19.x and 4.20.x.
It came in 5.0-rc1, so it fits the "in a Linus released kernel"
requirement. If we are to wait until it shows up in a -final, that
would be months too late for almost all of these types of patches that
are picked up.
> I don't know if Oleg considered backporting that patch. I certainly
> did (I always do), and I decided against doing so. Yet there it is.
This came in through Sasha's tools, which give people a week or so to
say "hey, this isn't a stable patch!" and it seems everyone ignored that
:(
Where is Kees's fix? I'll be glad to queue it up, or just revert the
above commit, which ever people think is easiest.
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-15 7:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 17:57 Userspace regression in LTS and stable kernels Samuel Dionne-Riel
2019-02-13 18:00 ` Samuel Dionne-Riel
2019-02-13 23:36 ` Richard Weinberger
2019-02-14 0:41 ` Samuel Dionne-Riel
2019-02-14 0:54 ` Kees Cook
2019-02-14 1:27 ` Samuel Dionne-Riel
2019-02-14 1:35 ` Kees Cook
2019-02-14 3:16 ` Samuel Dionne-Riel
2019-02-14 0:41 ` Kees Cook
2019-02-14 17:56 ` Linus Torvalds
2019-02-14 20:20 ` Andrew Morton
2019-02-15 7:00 ` Greg Kroah-Hartman [this message]
2019-02-15 7:13 ` Greg Kroah-Hartman
2019-02-15 9:10 ` Michal Hocko
2019-02-15 9:20 ` Greg Kroah-Hartman
2019-02-15 9:42 ` Michal Hocko
2019-02-15 15:19 ` Sasha Levin
2019-02-15 15:52 ` Michal Hocko
2019-02-15 16:18 ` Samuel Dionne-Riel
2019-02-15 18:02 ` Sasha Levin
2019-02-15 18:00 ` Sasha Levin
2019-02-18 12:56 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215070022.GD14473@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=graham@grahamc.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=oleg@redhat.com \
--cc=richard.weinberger@gmail.com \
--cc=samuel@dionne-riel.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).