* [PATCH] scsi: aacraid: Fix missing break in switch statement
@ 2019-02-15 21:42 Gustavo A. R. Silva
2019-02-27 14:33 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-15 21:42 UTC (permalink / raw)
To: Adaptec OEM Raid Solutions, James E.J. Bottomley,
Martin K. Petersen, Raghava Aditya Renukunta
Cc: linux-scsi, linux-kernel, Gustavo A. R. Silva, Kees Cook
Add missing break statement and fix identation issue.
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: 9cb62fa24e0d ("aacraid: Log firmware AIF messages")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/scsi/aacraid/commsup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 0bdc6b0f725f..e67e032936ef 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -1303,8 +1303,9 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr)
ADD : DELETE;
break;
}
- case AifBuManagerEvent:
- aac_handle_aif_bu(dev, aifcmd);
+ break;
+ case AifBuManagerEvent:
+ aac_handle_aif_bu(dev, aifcmd);
break;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: aacraid: Fix missing break in switch statement
2019-02-15 21:42 [PATCH] scsi: aacraid: Fix missing break in switch statement Gustavo A. R. Silva
@ 2019-02-27 14:33 ` Martin K. Petersen
2019-02-27 20:07 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2019-02-27 14:33 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Adaptec OEM Raid Solutions, James E.J. Bottomley,
Martin K. Petersen, Raghava Aditya Renukunta, linux-scsi,
linux-kernel, Kees Cook
Gustavo,
> Add missing break statement and fix identation issue.
So much bad indentation in this driver. Tried various tab widths and it
is still all over the place.
Anyway. After staring at the firmware header I have convinced myself
that your fix is correct. Applied to 5.1/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: aacraid: Fix missing break in switch statement
2019-02-27 14:33 ` Martin K. Petersen
@ 2019-02-27 20:07 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-27 20:07 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Adaptec OEM Raid Solutions, James E.J. Bottomley,
Raghava Aditya Renukunta, linux-scsi, linux-kernel, Kees Cook
On 2/27/19 8:33 AM, Martin K. Petersen wrote:
>
> Gustavo,
>
>> Add missing break statement and fix identation issue.
>
> So much bad indentation in this driver. Tried various tab widths and it
> is still all over the place.
>
> Anyway. After staring at the firmware header I have convinced myself
> that your fix is correct. Applied to 5.1/scsi-queue.
>
That's great.
Thanks, Martin.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-27 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 21:42 [PATCH] scsi: aacraid: Fix missing break in switch statement Gustavo A. R. Silva
2019-02-27 14:33 ` Martin K. Petersen
2019-02-27 20:07 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).