From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Martin Kepplinger <martink@posteo.de>
Cc: kuninori.morimoto.gx@renesas.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep()
Date: Sat, 16 Feb 2019 21:35:03 -0800 [thread overview]
Message-ID: <20190217053503.GC107793@dtor-ws> (raw)
In-Reply-To: <20190213111958.9031-1-martink@posteo.de>
On Wed, Feb 13, 2019 at 12:19:58PM +0100, Martin Kepplinger wrote:
> gpiod_set_value_cansleep() needs it's declaration in the corresponding
> header. This fixes build errors like
>
> drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power':
> >> drivers/input/touchscreen/st1232.c:146:3: error: implicit declaration of
> function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'?
> [-Werror=implicit-function-declaration]
> gpiod_set_value_cansleep(ts->reset_gpio, !poweron);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> gpio_set_value_cansleep
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Thanks Martin, I'll fold it into the original patch introducing gpiod so
we keep bisectability.
--
Dmitry
prev parent reply other threads:[~2019-02-17 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201902131841.xHSZ8Cvm%fengguang.wu@intel.com>
2019-02-13 11:19 ` [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep() Martin Kepplinger
2019-02-17 5:35 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190217053503.GC107793@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).