From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Doug Anderson <dianders@chromium.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-pm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>,
Kevin Hilman <khilman@kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 1/2] PM / Domains: Mark "name" const in genpd_dev_pm_attach_by_name()
Date: Mon, 18 Feb 2019 09:41:48 +0100 [thread overview]
Message-ID: <20190218084148.GD24924@kroah.com> (raw)
In-Reply-To: <20190218041514.yn76qm65k77etedr@vireshk-i7>
On Mon, Feb 18, 2019 at 09:45:14AM +0530, Viresh Kumar wrote:
> On 15-02-19, 07:47, Doug Anderson wrote:
> > Hi,
> > On Thu, Feb 14, 2019 at 7:02 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > >
> > > On 14-02-19, 10:12, Douglas Anderson wrote:
> > > > The genpd_dev_pm_attach_by_name() simply takes the name and passes it
> > > > to of_property_match_string() where the argument is "const char *".
> > > > Adding a const here allows a later patch to add a const to
> > > > dev_pm_domain_attach_by_name() which allows drivers to pass in a name
> > > > that was declared "const" in a driver.
> > > >
> > > > Fixes: 5d6be70add65 ("PM / Domains: Introduce option to attach a device by name to genpd")
> > >
> > > Not sure if this should be counted as a fix.
> >
> > I'm OK if the "Fixes" is stripped when applying or if someone tells me
> > to re-post without the Fixes--just let me know. In general I do a lot
> > of cherry-picks from upstream and I appreciate the Fixes tag helping
> > to link patches together. In this case if I picked the original patch
> > I'd definitely want this one too. Certainly, though, CCing stable
> > would make no sense in this case. ;-)
>
> I am not sure if this is being done right now or not, but I read/heard
> somewhere that stable has started picking "Fixes" patches directly as
> well even if they aren't cc'd to stable.
It's random, not always happening, and nothing you can rely on.
If you know this is a patch for older kernels, then always add the cc:
stable line, as the documentation says you have to do!
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-18 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 18:12 [PATCH 1/2] PM / Domains: Mark "name" const in genpd_dev_pm_attach_by_name() Douglas Anderson
2019-02-14 18:12 ` [PATCH 2/2] PM / Domains: Mark "name" const in dev_pm_domain_attach_by_name() Douglas Anderson
2019-02-14 18:23 ` Stephen Boyd
2019-02-15 10:27 ` Ulf Hansson
2019-02-15 15:42 ` Doug Anderson
2019-02-14 18:23 ` [PATCH 1/2] PM / Domains: Mark "name" const in genpd_dev_pm_attach_by_name() Stephen Boyd
2019-02-15 3:02 ` Viresh Kumar
2019-02-15 15:47 ` Doug Anderson
2019-02-18 4:15 ` Viresh Kumar
2019-02-18 8:41 ` Greg Kroah-Hartman [this message]
2019-02-15 10:27 ` Ulf Hansson
2019-02-19 10:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218084148.GD24924@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dianders@chromium.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).