From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF5FC43381 for ; Mon, 18 Feb 2019 14:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2524121902 for ; Mon, 18 Feb 2019 14:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498698; bh=s9pk6ACczLUjMgzErAPJQ5DIBIUrxu8ODIOS/gTMQnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=g1B4N6Od1u6gsc28icbm9mpfRqISE3c4SwhoK7Zpj7euJOesHqypakZ7P9uQsLTk7 syIdGY3THnydk/gb38aWDYYE3tCnWm7amqAl2CwJSuJCEb4LinpTFzi2HjqRupP+2m mpTt6aCx8KWc6d+a3pFv8DQQUE9vnGA/govSS+HU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390052AbfBROE4 (ORCPT ); Mon, 18 Feb 2019 09:04:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:47552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389083AbfBROEy (ORCPT ); Mon, 18 Feb 2019 09:04:54 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55782204FD; Mon, 18 Feb 2019 14:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498693; bh=s9pk6ACczLUjMgzErAPJQ5DIBIUrxu8ODIOS/gTMQnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2OFehZPZiY/pxAY6lov4wf2i/66XiWo+FJROVLgdKY8+KymCoCc9Q1Y7TcRYZfISc 2c7Hknd3kX8+d8QRDHVuKlyR0LyC7bWq4uySwcdbfN9/2jMvTqLNsCB4IG3blaVUEs hzkQOGl/YzWRom0EE2FWFBCVBNf13VUdS24E+B70= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Felipe Balbi Subject: [PATCH 4.4 090/143] usb: gadget: udc: net2272: Fix bitwise and boolean operations Date: Mon, 18 Feb 2019 14:43:38 +0100 Message-Id: <20190218133532.348180223@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133529.099444112@linuxfoundation.org> References: <20190218133529.099444112@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gustavo A. R. Silva commit 07c69f1148da7de3978686d3af9263325d9d60bd upstream. (!x & y) strikes again. Fix bitwise and boolean operations by enclosing the expression: intcsr & (1 << NET2272_PCI_IRQ) in parentheses, before applying the boolean operator '!'. Notice that this code has been there since 2011. So, it would be helpful if someone can double-check this. This issue was detected with the help of Coccinelle. Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/net2272.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2100,7 +2100,7 @@ static irqreturn_t net2272_irq(int irq, #if defined(PLX_PCI_RDK2) /* see if PCI int for us by checking irqstat */ intcsr = readl(dev->rdk2.fpga_base_addr + RDK2_IRQSTAT); - if (!intcsr & (1 << NET2272_PCI_IRQ)) { + if (!(intcsr & (1 << NET2272_PCI_IRQ))) { spin_unlock(&dev->lock); return IRQ_NONE; }