From: Jerome Glisse <jglisse@redhat.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Peter Xu" <peterx@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Michal Hocko" <mhocko@kernel.org>,
kvm@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] Restore change_pte optimization to its former glory
Date: Mon, 18 Feb 2019 22:33:58 -0500 [thread overview]
Message-ID: <20190219033358.GB8311@redhat.com> (raw)
In-Reply-To: <20190218174505.GD30645@redhat.com>
On Mon, Feb 18, 2019 at 12:45:05PM -0500, Andrea Arcangeli wrote:
> On Mon, Feb 18, 2019 at 11:04:13AM -0500, Jerome Glisse wrote:
> > So i run 2 exact same VMs side by side (copy of same COW image) and
> > built the same kernel tree inside each (that is the only important
> > workload that exist ;)) but the change_pte did not have any impact:
> >
> > before mean {real: 1358.250977, user: 16650.880859, sys: 839.199524, npages: 76855.390625}
> > before stdev {real: 6.744010, user: 108.863762, sys: 6.840437, npages: 1868.071899}
> > after mean {real: 1357.833740, user: 16685.849609, sys: 839.646973, npages: 76210.601562}
> > after stdev {real: 5.124797, user: 78.469360, sys: 7.009164, npages: 2468.017578}
> > without mean {real: 1358.501343, user: 16674.478516, sys: 837.791992, npages: 76225.203125}
> > without stdev {real: 5.541104, user: 97.998367, sys: 6.715869, npages: 1682.392578}
> >
> > Above is time taken by make inside each VM for all yes config. npages
> > is the number of page shared reported on the host at the end of the
> > build.
>
> Did you set /sys/kernel/mm/ksm/sleep_millisecs to 0?
>
> It would also help to remove the checksum check from mm/ksm.c:
>
> - if (rmap_item->oldchecksum != checksum) {
> - rmap_item->oldchecksum = checksum;
> - return;
> - }
>
> One way or another, /sys/kernel/mm/ksm/pages_shared and/or
> pages_sharing need to change significantly to be sure we're exercising
> the COW/merging code that uses change_pte. KSM is smart enough to
> merge only not frequently changing pages, and with the default KSM
> code this probably works too well for a kernel build.
>
> > Should we still restore change_pte() ? It does not hurt, but it does
> > not seems to help in anyway. Maybe you have a better benchmark i could
> > run ?
>
> We could also try a microbenchmark based on
> ltp/testcases/kernel/mem/ksm/ksm02.c that already should trigger a
> merge flood and a COW flood during its internal processing.
So using that and the checksum test removed there is an improvement,
roughly 7%~8% on time spends in the kernel:
before mean {real: 675.460632, user: 857.771423, sys: 215.929657, npages: 4773.066895}
before stdev {real: 37.035435, user: 4.395942, sys: 3.976172, npages: 675.352783}
after mean {real: 672.515503, user: 855.817322, sys: 200.902710, npages: 4899.000000}
after stdev {real: 37.340954, user: 4.051633, sys: 3.894153, npages: 742.413452}
I am guessing for kernel build this get lost in the noise and that
KSM changes do not have that much of an impact. So i will reposting
the mmu notifier changes shortly in hope to get them in 5.1 and i
will post the KVM part separatly shortly there after.
If there is any more testing you wish me to do let me know.
Cheers,
Jérôme
prev parent reply other threads:[~2019-02-19 3:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:37 [RFC PATCH 0/4] Restore change_pte optimization to its former glory jglisse
2019-01-31 18:37 ` [RFC PATCH 1/4] uprobes: use set_pte_at() not set_pte_at_notify() jglisse
2019-02-02 0:50 ` Andrea Arcangeli
2019-02-11 19:27 ` Jerome Glisse
2019-01-31 18:37 ` [RFC PATCH 2/4] mm/mmu_notifier: use unsigned for event field in range struct jglisse
2019-02-02 1:13 ` Andrea Arcangeli
2019-01-31 18:37 ` [RFC PATCH 3/4] mm/mmu_notifier: set MMU_NOTIFIER_USE_CHANGE_PTE flag where appropriate jglisse
2019-01-31 18:37 ` [RFC PATCH 4/4] kvm/mmu_notifier: re-enable the change_pte() optimization jglisse
2019-02-01 23:57 ` [RFC PATCH 0/4] Restore change_pte optimization to its former glory Andrea Arcangeli
2019-02-02 0:14 ` Andrea Arcangeli
2019-02-11 19:09 ` Jerome Glisse
2019-02-11 20:02 ` Andrea Arcangeli
2019-02-18 16:04 ` Jerome Glisse
2019-02-18 17:45 ` Andrea Arcangeli
2019-02-18 18:20 ` Jerome Glisse
2019-02-19 2:37 ` Peter Xu
2019-02-19 2:43 ` Jerome Glisse
2019-02-19 3:33 ` Jerome Glisse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219033358.GB8311@redhat.com \
--to=jglisse@redhat.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).