From: Kalle Valo <kvalo@codeaurora.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Lubomir Rintel <lkundrak@v3.sk>
Subject: Re: [PATCH 1/3] libertas_tf: move hardware callbacks to a separate structure
Date: Tue, 19 Feb 2019 15:13:23 +0000 (UTC) [thread overview]
Message-ID: <20190219151323.7EF24607EF@smtp.codeaurora.org> (raw)
In-Reply-To: <20190210195217.18817-2-lkundrak@v3.sk>
Lubomir Rintel <lkundrak@v3.sk> wrote:
> We'll need to talk to the firmware to get a hardware address before
> device is registered with ieee80211 subsystem at the end of
> lbtf_add_card(). Hooking the callbacks after that is too late.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
Failed to compile:
drivers/net/wireless/marvell/libertas_tf/main.c: In function 'lbtf_add_card':
drivers/net/wireless/marvell/libertas_tf/main.c:603:309: error: 'udev' undeclared (first use in this function); did you mean 'cdev'?
lbtf_deb_usbd(&udev->dev, "Error programming the firmware\n");
^
cdev
drivers/net/wireless/marvell/libertas_tf/main.c:603:309: note: each undeclared identifier is reported only once for each function it appears in
make[5]: *** [drivers/net/wireless/marvell/libertas_tf/main.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [drivers/net/wireless/marvell/libertas_tf] Error 2
make[3]: *** [drivers/net/wireless/marvell] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
3 patches set to Changes Requested.
10804885 [1/3] libertas_tf: move hardware callbacks to a separate structure
10804881 [2/3] libertas_tf: don't defer firmware loading until start()
10804883 [3/3] libertas_tf: get the MAC address before registering the device
--
https://patchwork.kernel.org/patch/10804885/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-02-19 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 19:52 [PATCH 0/3] libertas_tf: fix setting the hardware address Lubomir Rintel
2019-02-10 19:52 ` [PATCH 1/3] libertas_tf: move hardware callbacks to a separate structure Lubomir Rintel
2019-02-11 13:47 ` Steve deRosier
2019-02-19 15:13 ` Kalle Valo [this message]
2019-02-10 19:52 ` [PATCH 2/3] libertas_tf: don't defer firmware loading until start() Lubomir Rintel
2019-02-11 14:10 ` Steve deRosier
2019-02-10 19:52 ` [PATCH 3/3] libertas_tf: get the MAC address before registering the device Lubomir Rintel
2019-02-11 14:11 ` Steve deRosier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219151323.7EF24607EF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).