[PATCH] firmware: hardcode the debug message for -ENOENT

[PATCH] firmware: hardcode the debug message for -ENOENT

[yuankuiz]

 From d6892f54a81bf85ad011bfb8822567690713d575 Mon Sep 17 00:00:00 2001

When the return code of "-ENOENT" was printed inside
of the debug message, which could be hardcoded simply.

Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
---
  drivers/base/firmware_loader/main.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c 
b/drivers/base/firmware_loader/main.c
index 8e9213b..9ab1409 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device, 
struct fw_priv *fw_priv)
  		rc = kernel_read_file_from_path(path, &fw_priv->data, &size,
  						msize, id);
  		if (rc) {
-			if (rc == -ENOENT)
-				dev_dbg(device, "loading %s failed with error %d\n",
-					 path, rc);
-			else
+			if (rc != -ENOENT)
  				dev_warn(device, "loading %s failed with error %d\n",
  					 path, rc);
+			else
+				dev_dbg(device, "loading %s failed with error -ENOENT\n",
+					 path);
  			continue;
  		}
  		dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);
-- 
2.7.4

Re: [PATCH] firmware: hardcode the debug message for -ENOENT

[yuankuiz]

Hi,

     Refined at below.

 From bbd0d9c8f28eb78ca34353347c3d4092e88f000c Mon Sep 17 00:00:00 2001

When the return code of "-ENOENT" was printed inside
of the debug message, which could be hardcoded meaningfully.

Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
---
  drivers/base/firmware_loader/main.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c 
b/drivers/base/firmware_loader/main.c
index 8e9213b..7eaaf5e 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device, 
struct fw_priv *fw_priv)
                 rc = kernel_read_file_from_path(path, &fw_priv->data, 
&size,
                                                 msize, id);
                 if (rc) {
-                       if (rc == -ENOENT)
-                               dev_dbg(device, "loading %s failed with 
error %d\n",
-                                        path, rc);
-                       else
+                       if (rc != -ENOENT)
                                 dev_warn(device, "loading %s failed with 
error %d\n",
                                          path, rc);
+                       else
+                               dev_dbg(device, "loading %s failed for 
no such file or directory.\n",
+                                        path);
                         continue;
                 }
                 dev_dbg(device, "direct-loading %s\n", 
fw_priv->fw_name);
-- 
2.7.4


On 2019-01-14 03:19 PM, yuankuiz@codeaurora.org wrote:
> From d6892f54a81bf85ad011bfb8822567690713d575 Mon Sep 17 00:00:00 2001
> 

Re: [PATCH] firmware: hardcode the debug message for -ENOENT

[Luis Chamberlain]

On Mon, Jan 14, 2019 at 05:58:30PM +0800, yuankuiz@codeaurora.org wrote:
> Hi,
> 
>     Refined at below.
> 
> From bbd0d9c8f28eb78ca34353347c3d4092e88f000c Mon Sep 17 00:00:00 2001

This is all garbled, not sure why your patch looks all messed up.

Are you using git sendemail or something manual?

  Luis

> 
> When the return code of "-ENOENT" was printed inside
> of the debug message, which could be hardcoded meaningfully.
> 
> Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
> ---
>  drivers/base/firmware_loader/main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/base/firmware_loader/main.c
> b/drivers/base/firmware_loader/main.c
> index 8e9213b..7eaaf5e 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c
> @@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device,
> struct fw_priv *fw_priv)
>                 rc = kernel_read_file_from_path(path, &fw_priv->data, &size,
>                                                 msize, id);
>                 if (rc) {
> -                       if (rc == -ENOENT)
> -                               dev_dbg(device, "loading %s failed with
> error %d\n",
> -                                        path, rc);
> -                       else
> +                       if (rc != -ENOENT)
>                                 dev_warn(device, "loading %s failed with
> error %d\n",
>                                          path, rc);
> +                       else
> +                               dev_dbg(device, "loading %s failed for no
> such file or directory.\n",
> +                                        path);
>                         continue;
>                 }
>                 dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);
> -- 
> 2.7.4
> 
> 
> On 2019-01-14 03:19 PM, yuankuiz@codeaurora.org wrote:
> > From d6892f54a81bf85ad011bfb8822567690713d575 Mon Sep 17 00:00:00 2001
> > 

Re: [PATCH] firmware: hardcode the debug message for -ENOENT

[yuankuiz]

On 2019-02-05 07:30 AM, Luis Chamberlain wrote:
> On Mon, Jan 14, 2019 at 05:58:30PM +0800, yuankuiz@codeaurora.org 
> wrote:
>> Hi,
>> 
>>     Refined at below.
>> 
>> From bbd0d9c8f28eb78ca34353347c3d4092e88f000c Mon Sep 17 00:00:00 2001
> 
> This is all garbled, not sure why your patch looks all messed up.
> 
> Are you using git sendemail or something manual?
> 
>   Luis
> 
Done. Update it with resend it as below.

 From: John Zhao <yuankuiz@codeaurora.org>

When the return code of "-ENOENT" was printed inside
of the debug message, which could be hardcoded meaningful.

Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
---
  drivers/base/firmware_loader/main.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c 
b/drivers/base/firmware_loader/main.c
index 8e9213b..7eaaf5e 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device, 
struct fw_priv *fw_priv)
  		rc = kernel_read_file_from_path(path, &fw_priv->data, &size,
  						msize, id);
  		if (rc) {
-			if (rc == -ENOENT)
-				dev_dbg(device, "loading %s failed with error %d\n",
-					 path, rc);
-			else
+			if (rc != -ENOENT)
  				dev_warn(device, "loading %s failed with error %d\n",
  					 path, rc);
+			else
+				dev_dbg(device, "loading %s failed for no such file or 
directory.\n",
+					 path);
  			continue;
  		}
  		dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);
-- 
2.7.4

Re: [PATCH] firmware: hardcode the debug message for -ENOENT

[Luis Chamberlain]

On Sun, Feb 17, 2019 at 04:25:10PM +0800, yuankuiz@codeaurora.org wrote:
> On 2019-02-05 07:30 AM, Luis Chamberlain wrote:
> > On Mon, Jan 14, 2019 at 05:58:30PM +0800, yuankuiz@codeaurora.org wrote:
> > > Hi,
> > > 
> > >     Refined at below.
> > > 
> > > From bbd0d9c8f28eb78ca34353347c3d4092e88f000c Mon Sep 17 00:00:00 2001
> > 
> > This is all garbled, not sure why your patch looks all messed up.
> > 
> > Are you using git sendemail or something manual?
> > 
> >   Luis
> > 
> Done. Update it with resend it as below.

Sorry but I have not received it, can you resend?
While at it please address my comment below.

> From: John Zhao <yuankuiz@codeaurora.org>
> 
> When the return code of "-ENOENT" was printed inside
> of the debug message, which could be hardcoded meaningful.

This sentence doesn't read well. Please adjust it a bit to make
coherent sense, and resend it.

Perhaps you can use something like this:

We already issue a custom firmware debug print message when no file / path
was not found, however only the error code is returned. Stating clearly
that the file was not found is much more useful for debugging, so let's
be explicit about that.

  Luis

> 
> Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
> ---
>  drivers/base/firmware_loader/main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/base/firmware_loader/main.c
> b/drivers/base/firmware_loader/main.c
> index 8e9213b..7eaaf5e 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c
> @@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device,
> struct fw_priv *fw_priv)
>  		rc = kernel_read_file_from_path(path, &fw_priv->data, &size,
>  						msize, id);
>  		if (rc) {
> -			if (rc == -ENOENT)
> -				dev_dbg(device, "loading %s failed with error %d\n",
> -					 path, rc);
> -			else
> +			if (rc != -ENOENT)
>  				dev_warn(device, "loading %s failed with error %d\n",
>  					 path, rc);
> +			else
> +				dev_dbg(device, "loading %s failed for no such file or directory.\n",
> +					 path);
>  			continue;
>  		}
>  		dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);
> -- 
> 2.7.4

[PATCH v2] firmware: hardcode the debug message for -ENOENT

[yuankuiz]

 From: John Zhao <yuankuiz@codeaurora.org>

When no file /path was found, the error code of -ENOENT
enumerated in errno-base.h, is returned. Stating clearly that
the file was not found is much more useful for debugging, So
let's be explicit about that.

Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
---
  drivers/base/firmware_loader/main.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c 
b/drivers/base/firmware_loader/main.c
index 8e9213b..7eaaf5e 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device, 
struct fw_priv *fw_priv)
  		rc = kernel_read_file_from_path(path, &fw_priv->data, &size,
  						msize, id);
  		if (rc) {
-			if (rc == -ENOENT)
-				dev_dbg(device, "loading %s failed with error %d\n",
-					 path, rc);
-			else
+			if (rc != -ENOENT)
  				dev_warn(device, "loading %s failed with error %d\n",
  					 path, rc);
+			else
+				dev_dbg(device, "loading %s failed for no such file or 
directory.\n",
+					 path);
  			continue;
  		}
  		dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);
-- 

Re: [PATCH v2] firmware: hardcode the debug message for -ENOENT

[Luis Chamberlain]

On Wed, Feb 20, 2019 at 10:39:04AM +0800, yuankuiz@codeaurora.org wrote:
> From: John Zhao <yuankuiz@codeaurora.org>
> 
> When no file /path was found, the error code of -ENOENT
> enumerated in errno-base.h, is returned. Stating clearly that
> the file was not found is much more useful for debugging, So
> let's be explicit about that.
> 
> Signed-off-by: John Zhao <yuankuiz@codeaurora.org>

Acked-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis