From: Thierry Reding <thierry.reding@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: jonathanh@nvidia.com, talho@nvidia.com, wsa@the-dreams.de,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH V4 1/2] i2c: tegra: remove master fifo support on tegra186
Date: Tue, 19 Feb 2019 18:11:37 +0100 [thread overview]
Message-ID: <20190219171137.GC14351@ulmo> (raw)
In-Reply-To: <1550551825-1245-1-git-send-email-skomatineni@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]
On Mon, Feb 18, 2019 at 08:50:24PM -0800, Sowjanya Komatineni wrote:
> Tegra186 does not have master fifo control register and instead
> uses fifo control register like prior tegra chipset.
>
> This patch fixes this and prevents crashing during boot when
> accessing fifo control registers.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nit: fifo -> FIFO, tegra -> Tegra, but other than that:
Acked-by: Thierry Reding <treding@nvidia.com>
A quick note on why I'm pointing out these capitalization issues so
pedantically: specifically in the "tegra" case, it's difficult to grep
for it because it matches things like "integration", which is a
surprisingly common word in the kernel. Spelling it "Tegra" consistently
make it easier to grep for Tegra related bits specifically.
Thierry
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index a4cd79c9f7a7..e6851904acc1 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -1436,7 +1436,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
> .has_config_load_reg = true,
> .has_multi_master_mode = true,
> .has_slcg_override_reg = true,
> - .has_mst_fifo = true,
> + .has_mst_fifo = false,
> .quirks = &tegra_i2c_quirks,
> .supports_bus_clear = true,
> .has_apb_dma = false,
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-02-19 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 4:50 [PATCH V4 1/2] i2c: tegra: remove master fifo support on tegra186 Sowjanya Komatineni
2019-02-19 4:50 ` [PATCH V4 2/2] i2c: tegra: remove multi-master support Sowjanya Komatineni
2019-02-19 17:12 ` Thierry Reding
2019-02-19 17:11 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219171137.GC14351@ulmo \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=skomatineni@nvidia.com \
--cc=talho@nvidia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).