From: Eduardo Valentin <edubezval@gmail.com>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, andy.gross@linaro.org,
David Brown <david.brown@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 00/12] qcom: dts: thermal cleanups
Date: Tue, 19 Feb 2019 17:26:42 -0800 [thread overview]
Message-ID: <20190220012641.GH2811@localhost.localdomain> (raw)
In-Reply-To: <cover.1550493113.git.amit.kucheria@linaro.org>
Hey
On Mon, Feb 18, 2019 at 06:05:14PM +0530, Amit Kucheria wrote:
> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
> - split up the register address map for msm8998
> - standardize names of the various thermal-zones across boards to make it
> easy for test scripts to parse
>
I am generally fine with the effort but please fix the following
(applies for the whole series) wrt to required properties for DT
thermal:
a. Trip points for your zones
b. Cooling Mappings for zones that have passive trips.
> Amit Kucheria (12):
> arm64: dts: msm8998: thermal: split address space into two
> arm64: dts: msm8998: efficiency is not valid property
> arm64: dts: msm8916: thermal: Add sensor for modem
> arm64: dts: msm8996: thermal: Add temperature sensors near major
> peripherals
> arm64: dts: msm8998: thermal: Fix the cpu sensor numbers
> arm64: dts: msm8998: thermal: Fix the gpu sensor number
> arm64: dts: msm8998: thermal: GPU has two sensors, add the second
> arm64: dts: msm8998: thermal: Add temperature sensors near major
> peripherals
> arm64: dts: sdm845: thermal: Add temperature sensors near major
> peripherals
> arm64: dts: msm8998: thermal: Make trip names consistent
> arm64: dts: msm8916: thermal: Make trip names consistent
> arm64: dts: msm8996: thermal: Make trip names consistent
>
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 30 +++--
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 122 ++++++++++++++++++--
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 154 ++++++++++++++++++--------
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 91 +++++++++++++++
> 4 files changed, 328 insertions(+), 69 deletions(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-02-20 1:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 12:35 [PATCH v1 00/12] qcom: dts: thermal cleanups Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 01/12] arm64: dts: msm8998: thermal: split address space into two Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 02/12] arm64: dts: msm8998: efficiency is not valid property Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 03/12] arm64: dts: msm8916: thermal: Add sensor for modem Amit Kucheria
2019-02-20 1:24 ` Eduardo Valentin
2019-02-18 12:35 ` [PATCH v1 04/12] arm64: dts: msm8996: thermal: Add temperature sensors near major peripherals Amit Kucheria
2019-02-20 1:24 ` Eduardo Valentin
2019-02-20 9:18 ` Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 05/12] arm64: dts: msm8998: thermal: Fix the cpu sensor numbers Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 06/12] arm64: dts: msm8998: thermal: Fix the gpu sensor number Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 07/12] arm64: dts: msm8998: thermal: GPU has two sensors, add the second Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 08/12] arm64: dts: msm8998: thermal: Add temperature sensors near major peripherals Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 09/12] arm64: dts: sdm845: " Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 10/12] arm64: dts: msm8998: thermal: Make trip names consistent Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 11/12] arm64: dts: msm8916: " Amit Kucheria
2019-02-18 12:35 ` [PATCH v1 12/12] arm64: dts: msm8996: " Amit Kucheria
2019-02-20 1:26 ` Eduardo Valentin [this message]
2019-02-20 9:39 ` [PATCH v1 00/12] qcom: dts: thermal cleanups Amit Kucheria
2019-02-20 23:32 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220012641.GH2811@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).