From: Jonathan Cameron <jic23@kernel.org>
To: Stefan Popa <stefan.popa@analog.com>
Cc: <robh+dt@kernel.org>, <Michael.Hennerich@analog.com>,
<knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-iio@vger.kernel.org>
Subject: Re: [PATCH 5/6] iio: imu: adis16480: Add support for ADIS1649x family of devices
Date: Wed, 20 Feb 2019 10:40:49 +0000 [thread overview]
Message-ID: <20190220104049.443106ef@archlinux> (raw)
In-Reply-To: <1550596338-24220-6-git-send-email-stefan.popa@analog.com>
On Tue, 19 Feb 2019 19:12:17 +0200
Stefan Popa <stefan.popa@analog.com> wrote:
> The ADIS16495 and ADIS16497 are inertial systems that include a triaxis
> gyroscope and a triaxis accelerometer. The serial peripheral interface
> (SPI) provide a simple interface for data collection and configuration
> control. The devices are similar to ADIS16475, ADIS16480, ADIS16485 and
> ADIS16488, the main differences are related to range and scale factors.
>
> The temperature data scale is 0.00565 C/LSB for ADIS16475 and ADIS1648x
> devices, while for ADIS1649x 0.0125 C/LSB.
>
> Another difference is that ADIS1649x devices support different gyroscope
> measurement ranges which are dependent on the dash number (-1, -2, -3),
> see Table 24 in the ADIS16495 datasheet. However, the ADIS16497
> gyroscopes have the same scale as ADIS16495.
>
> Furthermore, ADIS16495 devices support the acceleration maximum range of
> 8g, while ADIS16497 devices go up to 40g.
>
> Datasheets:
> Link: https://www.analog.com/media/en/technical-documentation/data-sheets/adis16495.pdf
> Link: https://www.analog.com/media/en/technical-documentation/data-sheets/adis16497.pdf
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
Looks fine, but will probably change with the tweaks suggested for earlier
patches.
Thanks,
Jonathan
> ---
> drivers/iio/imu/adis16480.c | 72 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index cc53825..c30acfdb 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -714,6 +714,12 @@ enum adis16480_variant {
> ADIS16480,
> ADIS16485,
> ADIS16488,
> + ADIS16495_1,
> + ADIS16495_2,
> + ADIS16495_3,
> + ADIS16497_1,
> + ADIS16497_2,
> + ADIS16497_3,
> };
>
> static const struct adis16480_chip_info adis16480_chip_info[] = {
> @@ -758,6 +764,60 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
> .accel_max_scale = 18,
> .temp_max_scale = 10619,
> },
> + [ADIS16495_1] = {
> + .channels = adis16485_channels,
> + .num_channels = ARRAY_SIZE(adis16485_channels),
> + .gyro_max_val = IIO_RAD_TO_DEGREE(20000),
> + .gyro_max_scale = 125,
> + .accel_max_val = IIO_M_S_2_TO_G(32000),
> + .accel_max_scale = 8,
> + .temp_max_scale = 4800,
> + },
> + [ADIS16495_2] = {
> + .channels = adis16485_channels,
> + .num_channels = ARRAY_SIZE(adis16485_channels),
> + .gyro_max_val = IIO_RAD_TO_DEGREE(18000),
> + .gyro_max_scale = 450,
> + .accel_max_val = IIO_M_S_2_TO_G(32000),
> + .accel_max_scale = 8,
> + .temp_max_scale = 4800,
> + },
> + [ADIS16495_3] = {
> + .channels = adis16485_channels,
> + .num_channels = ARRAY_SIZE(adis16485_channels),
> + .gyro_max_val = IIO_RAD_TO_DEGREE(20000),
> + .gyro_max_scale = 2000,
> + .accel_max_val = IIO_M_S_2_TO_G(32000),
> + .accel_max_scale = 8,
> + .temp_max_scale = 4800,
> + },
> + [ADIS16497_1] = {
> + .channels = adis16485_channels,
> + .num_channels = ARRAY_SIZE(adis16485_channels),
> + .gyro_max_val = IIO_RAD_TO_DEGREE(20000),
> + .gyro_max_scale = 125,
> + .accel_max_val = IIO_M_S_2_TO_G(32000),
> + .accel_max_scale = 40,
> + .temp_max_scale = 4800,
> + },
> + [ADIS16497_2] = {
> + .channels = adis16485_channels,
> + .num_channels = ARRAY_SIZE(adis16485_channels),
> + .gyro_max_val = IIO_RAD_TO_DEGREE(18000),
> + .gyro_max_scale = 450,
> + .accel_max_val = IIO_M_S_2_TO_G(32000),
> + .accel_max_scale = 40,
> + .temp_max_scale = 4800,
> + },
> + [ADIS16497_3] = {
> + .channels = adis16485_channels,
> + .num_channels = ARRAY_SIZE(adis16485_channels),
> + .gyro_max_val = IIO_RAD_TO_DEGREE(20000),
> + .gyro_max_scale = 2000,
> + .accel_max_val = IIO_M_S_2_TO_G(32000),
> + .accel_max_scale = 40,
> + .temp_max_scale = 4800,
> + },
> };
>
> static const struct iio_info adis16480_info = {
> @@ -1000,6 +1060,12 @@ static const struct spi_device_id adis16480_ids[] = {
> { "adis16480", ADIS16480 },
> { "adis16485", ADIS16485 },
> { "adis16488", ADIS16488 },
> + { "adis16495-1", ADIS16495_1 },
> + { "adis16495-2", ADIS16495_2 },
> + { "adis16495-3", ADIS16495_3 },
> + { "adis16497-1", ADIS16497_1 },
> + { "adis16497-2", ADIS16497_2 },
> + { "adis16497-3", ADIS16497_3 },
> { }
> };
> MODULE_DEVICE_TABLE(spi, adis16480_ids);
> @@ -1009,6 +1075,12 @@ static const struct of_device_id adis16480_of_match[] = {
> { .compatible = "adi,adis16480" },
> { .compatible = "adi,adis16485" },
> { .compatible = "adi,adis16488" },
> + { .compatible = "adi,adis16495-1" },
> + { .compatible = "adi,adis16495-2" },
> + { .compatible = "adi,adis16495-3" },
> + { .compatible = "adi,adis16497-1" },
> + { .compatible = "adi,adis16497-2" },
> + { .compatible = "adi,adis16497-3" },
> { },
> };
> MODULE_DEVICE_TABLE(of, adis16480_of_match);
next prev parent reply other threads:[~2019-02-20 10:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 17:12 [PATCH 0/6] iio: imu: adis16480: Add support for ADIS1649x family of devices Stefan Popa
2019-02-19 17:12 ` [PATCH 1/6] iio: imu: adis16480: Use the default data ready pin configuration Stefan Popa
2019-02-20 10:20 ` Jonathan Cameron
2019-02-19 17:12 ` [PATCH 2/6] iio: imu: adis16480: Add support for configurable drdy indicator Stefan Popa
2019-02-20 10:29 ` Jonathan Cameron
2019-02-20 10:42 ` Popa, Stefan Serban
2019-02-19 17:12 ` [PATCH 3/6] iio: imu: adis16480: Add OF device ID table Stefan Popa
2019-02-20 10:30 ` Jonathan Cameron
2019-02-19 17:12 ` [PATCH 4/6] iio: imu: adis16480: Treat temperature scale in a generic way Stefan Popa
2019-02-20 10:37 ` Jonathan Cameron
2019-02-19 17:12 ` [PATCH 5/6] iio: imu: adis16480: Add support for ADIS1649x family of devices Stefan Popa
2019-02-20 10:40 ` Jonathan Cameron [this message]
2019-02-19 17:12 ` [PATCH 6/6] iio: imu: adis16480: Add docs for ADIS16480 IMU Stefan Popa
2019-02-20 10:46 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220104049.443106ef@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).