From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECB5C43381 for ; Wed, 20 Feb 2019 14:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 187AC2183F for ; Wed, 20 Feb 2019 14:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbfBTOe6 (ORCPT ); Wed, 20 Feb 2019 09:34:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53586 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbfBTOe6 (ORCPT ); Wed, 20 Feb 2019 09:34:58 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A57C9C0AC378; Wed, 20 Feb 2019 14:34:57 +0000 (UTC) Received: from krava (unknown [10.43.17.20]) by smtp.corp.redhat.com (Postfix) with SMTP id 65DAD36FB; Wed, 20 Feb 2019 14:34:55 +0000 (UTC) Date: Wed, 20 Feb 2019 15:34:54 +0100 From: Jiri Olsa To: Jonas Rabenstein Cc: linux-perf-users@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Andi Kleen , Thomas Richter , Stephane Eranian , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] perf evsel: add support for inlined function in callchains Message-ID: <20190220143454.GD25423@krava> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 20 Feb 2019 14:34:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 19, 2019 at 07:38:08PM +0100, Jonas Rabenstein wrote: > Hi, > sample__fprintf_callchain currently did not use the already available > code to get the symbols of an inlined function if such information is > available in a dso. This patchset adds the required logic to add > appropriate lines. > > As I am quite new to the code base of perf I am not sure how to test > that changeset in a correct way. At least the codes builds and the tools > that make use of sample__fprintf_callchain (perf-script, perf-trace and > perf-sched as far as I can see) did not fail to run - also I did not get > into the details of perf-trace and perf-sched as I have never used them > before. you could provide some examples that shows what u changed I can see your changes change the perf script callchains, displaying less or different callchains: --- old 2019-02-20 15:29:34.872312007 +0100 +++ new 2019-02-20 15:30:47.784725456 +0100 @@ -23,10 +23,9 @@ yes 11807 203482.590491: 246238 cycl 40 [unknown] ([unknown]) yes 11807 203482.590654: 534592 cycles:uppp: - 7f83e3c7fd0c _dl_addr+0x11c (/usr/lib64/libc-2.27.so) + 7f83e3c7fd0c __GI__dl_addr+0x11c (inlined) yes 11807 203482.592371: 455976 cycles:uppp: - 55ddec8a3f6e [unknown] (/usr/bin/yes) a790a790a790a79 [unknown] ([unknown]) yes 11807 203482.594176: 326514 cycles:uppp: @@ -38,11 +37,9 @@ yes 11807 203482.595464: 262867 cycl a790a790a790a79 [unknown] ([unknown]) yes 11807 203482.596502: 214762 cycles:uppp: - 55ddec8a3f6e [unknown] (/usr/bin/yes) a790a790a790a79 [unknown] ([unknown]) > > Another thing I am not sure how to deal with are some warnings of > checkpatch.pl due to the 80 character line limit. Due to the long > function names in use the current implementation already exceeded that > limit in the same spots by even more characters as I have taken the > inner loop and put it into a separate function. don't worry much about the long lines warnings > > I hope to expand my work to perf-report but thought it might be usefull > to get already early feedback on those patches. yep, good idea thanks, jirka