From: Will Deacon <will.deacon@arm.com>
To: Waiman Long <longman@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-c6x-dev@linux-c6x.org,
uclinux-h8-devel@lists.sourceforge.jp,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
linux-arch@vger.kernel.org, x86@kernel.org,
Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH v4 1/3] locking/rwsem: Remove arch specific rwsem files
Date: Wed, 20 Feb 2019 14:47:17 +0000 [thread overview]
Message-ID: <20190220144717.GI7523@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <1550095217-12047-2-git-send-email-longman@redhat.com>
On Wed, Feb 13, 2019 at 05:00:15PM -0500, Waiman Long wrote:
> As the generic rwsem-xadd code is using the appropriate acquire and
> release versions of the atomic operations, the arch specific rwsem.h
> files will not be that much faster than the generic code as long as the
> atomic functions are properly implemented. So we can remove those arch
> specific rwsem.h and stop building asm/rwsem.h to reduce maintenance
> effort.
>
> Currently, only x86, alpha and ia64 have implemented architecture
> specific fast paths. I don't have access to alpha and ia64 systems for
> testing, but they are legacy systems that are not likely to be updated
> to the latest kernel anyway.
>
> By using a rwsem microbenchmark, the total locking rates on a 4-socket
> 56-core 112-thread x86-64 system before and after the patch were as
> follows (mixed means equal # of read and write locks):
>
> Before Patch After Patch
> # of Threads wlock rlock mixed wlock rlock mixed
> ------------ ----- ----- ----- ----- ----- -----
> 1 29,201 30,143 29,458 28,615 30,172 29,201
> 2 6,807 13,299 1,171 7,725 15,025 1,804
> 4 6,504 12,755 1,520 7,127 14,286 1,345
> 8 6,762 13,412 764 6,826 13,652 726
> 16 6,693 15,408 662 6,599 15,938 626
> 32 6,145 15,286 496 5,549 15,487 511
> 64 5,812 15,495 60 5,858 15,572 60
>
> There were some run-to-run variations for the multi-thread tests. For
> x86-64, using the generic C code fast path seems to be a little bit
> faster than the assembly version with low lock contention. Looking at
> the assembly version of the fast paths, there are assembly to/from C
> code wrappers that save and restore all the callee-clobbered registers
> (7 registers on x86-64). The assembly generated from the generic C
> code doesn't need to do that. That may explain the slight performance
> gain here.
>
> The generic asm rwsem.h can also be merged into kernel/locking/rwsem.h
> with no code change as no other code other than those under
> kernel/locking needs to access the internal rwsem macros and functions.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
> MAINTAINERS | 1 -
> arch/alpha/include/asm/rwsem.h | 211 -----------------------------------
> arch/arm/include/asm/Kbuild | 1 -
> arch/arm64/include/asm/Kbuild | 1 -
> arch/hexagon/include/asm/Kbuild | 1 -
> arch/ia64/include/asm/rwsem.h | 172 -----------------------------
> arch/powerpc/include/asm/Kbuild | 1 -
> arch/s390/include/asm/Kbuild | 1 -
> arch/sh/include/asm/Kbuild | 1 -
> arch/sparc/include/asm/Kbuild | 1 -
> arch/x86/include/asm/rwsem.h | 237 ----------------------------------------
> arch/x86/lib/Makefile | 1 -
> arch/x86/lib/rwsem.S | 156 --------------------------
> arch/x86/um/Makefile | 1 -
> arch/xtensa/include/asm/Kbuild | 1 -
> include/asm-generic/rwsem.h | 140 ------------------------
> include/linux/rwsem.h | 4 +-
> kernel/locking/percpu-rwsem.c | 2 +
> kernel/locking/rwsem.h | 130 ++++++++++++++++++++++
> 19 files changed, 133 insertions(+), 930 deletions(-)
> delete mode 100644 arch/alpha/include/asm/rwsem.h
> delete mode 100644 arch/ia64/include/asm/rwsem.h
> delete mode 100644 arch/x86/include/asm/rwsem.h
> delete mode 100644 arch/x86/lib/rwsem.S
> delete mode 100644 include/asm-generic/rwsem.h
Looks like a nice cleanup, thanks:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2019-02-20 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 22:00 [PATCH v4 0/3] locking/rwsem: Rwsem rearchitecture part 0 Waiman Long
2019-02-13 22:00 ` [PATCH v4 1/3] locking/rwsem: Remove arch specific rwsem files Waiman Long
2019-02-20 14:47 ` Will Deacon [this message]
2019-02-13 22:00 ` [PATCH v4 2/3] locking/rwsem: Remove rwsem-spinlock.c & use rwsem-xadd.c for all archs Waiman Long
2019-02-14 10:54 ` Geert Uytterhoeven
2019-02-14 11:12 ` Peter Zijlstra
2019-02-20 14:47 ` Will Deacon
2019-02-13 22:00 ` [PATCH v4 3/3] locking/rwsem: Optimize down_read_trylock() Waiman Long
2019-02-21 14:14 ` Will Deacon
2019-02-22 3:28 ` Waiman Long
2019-02-14 10:37 ` [PATCH v4 0/3] locking/rwsem: Rwsem rearchitecture part 0 Peter Zijlstra
2019-02-14 22:05 ` Waiman Long
2019-02-15 18:40 ` Will Deacon
2019-02-15 18:58 ` Waiman Long
2019-02-18 14:58 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220144717.GI7523@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave@stgolabs.net \
--cc=hpa@zytor.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=nios2-dev@lists.rocketboards.org \
--cc=openrisc@lists.librecores.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).