From: Michal Hocko <mhocko@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Yue Hu <zbestahu@gmail.com>,
akpm@linux-foundation.org, rientjes@google.com, joe@perches.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
huyue2@yulong.com
Subject: Re: [PATCH] mm/cma_debug: Check for null tmp in cma_debugfs_add_one()
Date: Thu, 21 Feb 2019 09:45:25 +0100 [thread overview]
Message-ID: <20190221084525.GI4525@dhcp22.suse.cz> (raw)
In-Reply-To: <20190221083624.GD6397@kroah.com>
On Thu 21-02-19 09:36:24, Greg KH wrote:
> On Thu, Feb 21, 2019 at 09:23:09AM +0100, Michal Hocko wrote:
> > On Thu 21-02-19 12:01:30, Yue Hu wrote:
> > > From: Yue Hu <huyue2@yulong.com>
> > >
> > > If debugfs_create_dir() failed, the following debugfs_create_file()
> > > will be meanless since it depends on non-NULL tmp dentry and it will
> > > only waste CPU resource.
> >
> > The file will be created in the debugfs root. But, more importantly.
> > Greg (CCed now) is working on removing the failure paths because he
> > believes they do not really matter for debugfs and they make code more
> > ugly. More importantly a check for NULL is not correct because you
> > get ERR_PTR after recent changes IIRC.
> >
> > >
> > > Signed-off-by: Yue Hu <huyue2@yulong.com>
> > > ---
> > > mm/cma_debug.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/mm/cma_debug.c b/mm/cma_debug.c
> > > index 2c2c869..3e9d984 100644
> > > --- a/mm/cma_debug.c
> > > +++ b/mm/cma_debug.c
> > > @@ -169,6 +169,8 @@ static void cma_debugfs_add_one(struct cma *cma, struct dentry *root_dentry)
> > > scnprintf(name, sizeof(name), "cma-%s", cma->name);
> > >
> > > tmp = debugfs_create_dir(name, root_dentry);
> > > + if (!tmp)
> > > + return;
>
> Ick, yes, this patch isn't ok, I've been doing lots of work to rip these
> checks out :)
Btw. I believe that it would help to clarify this stance in the
kerneldoc otherwise these checks will be returning back because the
general kernel development attitude is to check for errors. As I've said
previously debugfs being different is ugly but decision is yours.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-02-21 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 4:01 [PATCH] mm/cma_debug: Avoid to use global cma_debugfs_root Yue Hu
2019-02-21 4:01 ` [PATCH] mm/cma_debug: Check for null tmp in cma_debugfs_add_one() Yue Hu
2019-02-21 8:23 ` Michal Hocko
2019-02-21 8:36 ` Greg KH
2019-02-21 8:45 ` Michal Hocko [this message]
2019-02-21 9:10 ` Greg KH
2019-02-21 8:56 ` Yue Hu
2019-02-21 9:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221084525.GI4525@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=huyue2@yulong.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).