From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andy@infradead.org>,
Hans de Goede <hdegoede@redhat.com>,
Darren Hart <dvhart@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] platform/x86: intel_cht_int33fe: Provide fwnode for the USB connector
Date: Thu, 21 Feb 2019 11:35:08 +0200 [thread overview]
Message-ID: <20190221093508.GF5054@kuha.fi.intel.com> (raw)
In-Reply-To: <CAHp75VcoqwP5VrOW60XtQHLAO1KOmc_Kyn-KQsZC-tsiwpQq3A@mail.gmail.com>
On Wed, Feb 20, 2019 at 05:55:21PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 19, 2019 at 2:00 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > In ACPI, and now also in DT, the USB connectors usually have
> > their own device nodes. In case of USB Type-C, those
> > connector (port) nodes are child nodes of the controller or
> > PHY device, in our case the fusb302. The software fwnodes
> > allow us to create a similar child node for fusb302 that
> > represents the connector also on Intel CHT.
> >
> > This makes it possible replace the fusb302 specific device
> > properties which were deprecated with the common USB
> > connector properties that tcpm.c is able to use directly.
>
> > + /* Node for the FUSB302 controller */
> > + data->fusb302_node = fwnode_create_software_node(fusb302_props, NULL);
> > + if (IS_ERR(data->fusb302_node))
> > + return PTR_ERR(data->fusb302_node);
> > +
> > + /* Node for the connector (FUSB302 is the parent) */
> > + data->port_node = fwnode_create_software_node(usb_connector_props,
> > + data->fusb302_node);
> > + if (IS_ERR(data->port_node)) {
>
> > + fwnode_remove_software_node(data->fusb302_node);
>
> Sounds like a candidate for
> devm_fwnode_create_software_node()
If you don't mind, let's think about that later.
I'm not comfortable at all with the idea of introducing
devm_fwnode_create_software_node(). I would like to talk about that
separately. It's not going to be a problem to change this driver later
even if we decide to add the function.
thanks,
--
heikki
next prev parent reply other threads:[~2019-02-21 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 11:59 [PATCH 0/2] platform/x86: intel_cht_int33fe: Start using software nodes Heikki Krogerus
2019-02-19 11:59 ` [PATCH 1/2] platform/x86: intel_cht_int33fe: Provide fwnode for the USB connector Heikki Krogerus
2019-02-20 15:55 ` Andy Shevchenko
2019-02-21 9:35 ` Heikki Krogerus [this message]
2019-02-21 13:23 ` Andy Shevchenko
2019-02-21 13:46 ` Andy Shevchenko
2019-02-21 13:56 ` Heikki Krogerus
2019-02-21 14:21 ` Andy Shevchenko
2019-02-19 11:59 ` [PATCH 2/2] platform/x86: intel_cht_int33fe: Create fwnode for max17047 Heikki Krogerus
2019-02-22 16:31 ` [PATCH 0/2] platform/x86: intel_cht_int33fe: Start using software nodes Hans de Goede
2019-02-25 15:48 ` Heikki Krogerus
2019-02-25 19:14 ` Hans de Goede
2019-02-27 9:37 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221093508.GF5054@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).