From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] perf record: implement -z=<level> and --mmap-flush=<thres> options
Date: Thu, 21 Feb 2019 10:49:06 +0100 [thread overview]
Message-ID: <20190221094906.GD10990@krava> (raw)
In-Reply-To: <d3b3ccaf-c8d2-03f7-580e-f3318b1650d2@linux.intel.com>
On Wed, Feb 20, 2019 at 06:24:30PM +0300, Alexey Budankov wrote:
>
> On 12.02.2019 16:08, Jiri Olsa wrote:
> > On Mon, Feb 11, 2019 at 11:22:38PM +0300, Alexey Budankov wrote:
> >
> > SNIP
> >
> >> +static int perf_mmap__aio_mmap_blocks(struct perf_mmap *map);
> >> +
> >> static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp)
> >> {
> >> - int delta_max, i, prio, ret;
> >> + int i, ret = 0, init_blocks = 1;
> >>
> >> map->aio.nr_cblocks = mp->nr_cblocks;
> >> + if (map->aio.nr_cblocks == -1) {
> >> + map->aio.nr_cblocks = 1;
> >> + init_blocks = 0;
> >> + }
> >> +
> >> if (map->aio.nr_cblocks) {
> >> - map->aio.aiocb = calloc(map->aio.nr_cblocks, sizeof(struct aiocb *));
> >> - if (!map->aio.aiocb) {
> >> - pr_debug2("failed to allocate aiocb for data buffer, error %m\n");
> >> - return -1;
> >> - }
> >> - map->aio.cblocks = calloc(map->aio.nr_cblocks, sizeof(struct aiocb));
> >> - if (!map->aio.cblocks) {
> >> - pr_debug2("failed to allocate cblocks for data buffer, error %m\n");
> >> - return -1;
> >> - }
> >> map->aio.data = calloc(map->aio.nr_cblocks, sizeof(void *));
> >> if (!map->aio.data) {
> >> pr_debug2("failed to allocate data buffer, error %m\n");
> >> return -1;
> >> }
> >> - delta_max = sysconf(_SC_AIO_PRIO_DELTA_MAX);
> >> for (i = 0; i < map->aio.nr_cblocks; ++i) {
> >> ret = perf_mmap__aio_alloc(map, i);
> >> if (ret == -1) {
> >> @@ -251,29 +245,16 @@ static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp)
> >> ret = perf_mmap__aio_bind(map, i, map->cpu, mp->affinity);
> >> if (ret == -1)
> >> return -1;
> >> - /*
> >> - * Use cblock.aio_fildes value different from -1
> >> - * to denote started aio write operation on the
> >> - * cblock so it requires explicit record__aio_sync()
> >> - * call prior the cblock may be reused again.
> >> - */
> >> - map->aio.cblocks[i].aio_fildes = -1;
> >> - /*
> >> - * Allocate cblocks with priority delta to have
> >> - * faster aio write system calls because queued requests
> >> - * are kept in separate per-prio queues and adding
> >> - * a new request will iterate thru shorter per-prio
> >> - * list. Blocks with numbers higher than
> >> - * _SC_AIO_PRIO_DELTA_MAX go with priority 0.
> >> - */
> >> - prio = delta_max - i;
> >> - map->aio.cblocks[i].aio_reqprio = prio >= 0 ? prio : 0;
> >> }
> >> + if (init_blocks)
> >> + ret = perf_mmap__aio_mmap_blocks(map);
> >> }
> >>
> >> - return 0;
> >> + return ret;
> >> }
> >
> > SNIP
> >
> > it seems like little refactoring happened in here (up and down) for
> > aio code, which is not explained and I'm unable to follow it.. please
> > separate this in simple change
>
> AIO buffers management has been taken out of HAVE_AIO_SUPPORT define
> to be used for compression in case of serial streaming. It will be
> revisited after other issues are addressed.
as I said earlier, please separate this from aio
jirka
next prev parent reply other threads:[~2019-02-21 9:49 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 20:17 [PATCH v2 0/4] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-02-11 20:21 ` [PATCH v2 1/4] feature: realize libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
2019-02-11 20:22 ` [PATCH v2 2/4] perf record: implement -z=<level> and --mmap-flush=<thres> options Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:13 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:13 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 15:24 ` Alexey Budankov
2019-02-21 9:49 ` Jiri Olsa [this message]
2019-02-21 11:24 ` Alexey Budankov
2019-02-25 15:27 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:15 ` Alexey Budankov
2019-02-21 9:47 ` Jiri Olsa
2019-02-21 11:23 ` Alexey Budankov
2019-02-25 15:26 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:13 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:19 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:25 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:14 ` Alexey Budankov
2019-02-25 15:30 ` Alexey Budankov
2019-02-11 20:23 ` [PATCH v2 3/4] perf record: enable runtime trace compression Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 15:13 ` Alexey Budankov
2019-02-21 9:43 ` Jiri Olsa
2019-02-21 11:30 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:53 ` Alexey Budankov
2019-02-21 9:43 ` Jiri Olsa
2019-02-21 11:18 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:09 ` Alexey Budankov
2019-02-25 15:27 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:11 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:03 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:06 ` Alexey Budankov
2019-02-11 20:25 ` [PATCH v2 4/4] perf report: support record trace file decompression Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 15:19 ` Alexey Budankov
2019-02-25 15:28 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:48 ` Alexey Budankov
[not found] ` <0132ec08-e28b-4102-5053-8f8e21e7fd44@linux.intel.com>
2019-02-27 10:56 ` Alexey Budankov
2019-02-27 11:17 ` Jiri Olsa
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:46 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:44 ` Alexey Budankov
2019-02-12 12:27 ` [PATCH v2 0/4] perf: enable compression of record mode trace to save storage space Arnaldo Carvalho de Melo
2019-02-12 14:06 ` Alexey Budankov
-- strict thread matches above, loose matches on Subject: below --
2019-01-28 7:02 Alexey Budankov
2019-01-28 7:08 ` [PATCH v2 2/4] perf record: implement -z=<level> and --mmap-flush=<thres> options Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221094906.GD10990@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).