From: "Ronald Tschalär" <ronald@innovation.ch>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>
Cc: Lukas Wunner <lukas@wunner.de>,
Federico Lorenzi <federico@travelground.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] Add Apple SPI keyboard and trackpad driver
Date: Thu, 21 Feb 2019 02:56:07 -0800 [thread overview]
Message-ID: <20190221105609.5710-1-ronald@innovation.ch> (raw)
This changeset adds a driver for the SPI keyboard and trackpad on recent
MacBook's and MacBook Pro's. The driver has seen a fair amount of use
over the last 2 years (basically anybody running linux on these
machines), with only relatively small changes in the last year or so.
For those interested, the driver development has been hosted at
https://github.com/cb22/macbook12-spi-driver/ (as well as my clone at
https://github.com/roadrunner2/macbook12-spi-driver/).
The first patch is just a placeholder for now and is provided in case
somebody wants to compile the driver while it's being reviewed here; the
real patch has been submitted to dri-devel and is being discussed there,
with the intent/hope that I can get an Ack and permission to merge it
through the input subsystem tree here as part of this patch series.
Changes in v2:
Applied all feedback from review by Andy Shevchenko, including:
- reworked logging to use dev_xxx() everywhere
- split 16-bit model_id field into 2 8-bit fields
- factored out several pieces of code into separate functions
- many code style improvements and cleanups
- Kconfig dependency fixes
The full set of changes (except for the Kconfig) can be viewed at
https://github.com/roadrunner2/macbook12-spi-driver/ as individual
commits a651bb9..f832caa in the upstreaming-review branch.
Ronald Tschalär (2):
drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.
Input: add Apple SPI keyboard and trackpad driver.
drivers/gpu/drm/bridge/Kconfig | 2 +-
drivers/input/keyboard/Kconfig | 14 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/applespi.c | 2003 +++++++++++++++++++++++++++++
4 files changed, 2019 insertions(+), 1 deletion(-)
create mode 100644 drivers/input/keyboard/applespi.c
--
2.20.1
next reply other threads:[~2019-02-21 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:56 Ronald Tschalär [this message]
2019-02-21 10:56 ` [PATCH v2 1/2] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Ronald Tschalär
2019-02-21 10:56 ` [PATCH v2 2/2] Input: add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-02-25 8:05 ` Life is hard, and then you die
2019-02-26 8:51 ` Andy Shevchenko
2019-02-26 9:20 ` Andy Shevchenko
2019-02-27 7:29 ` Life is hard, and then you die
2019-03-19 14:59 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221105609.5710-1-ronald@innovation.ch \
--to=ronald@innovation.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=federico@travelground.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).