From: Will Deacon <will.deacon@arm.com>
To: Waiman Long <longman@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH-tip v2 04/10] locking/rwsem: Micro-optimize rwsem_try_read_lock_unqueued()
Date: Thu, 21 Feb 2019 14:15:14 +0000 [thread overview]
Message-ID: <20190221141514.GE12696@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <1550263810-31947-5-git-send-email-longman@redhat.com>
On Fri, Feb 15, 2019 at 03:50:04PM -0500, Waiman Long wrote:
> The atomic_long_cmpxchg_acquire() in rwsem_try_read_lock_unqueued() is
> replaced by atomic_long_try_cmpxchg_acquire() to simpify the code and
> generate slightly better assembly code. There is no functional change.
Might be nice to illustrate the improvement in the commit message, but
it seems that try_cmpxchg is generally preferred for x86, so:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2019-02-21 14:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 20:50 [PATCH-tip v2 00/10] locking/rwsem: Rwsem rearchitecture part 1 Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 01/10] locking/rwsem: Relocate rwsem_down_read_failed() Waiman Long
2019-02-21 14:14 ` Will Deacon
2019-02-15 20:50 ` [PATCH-tip v2 02/10] locking/rwsem: Move owner setting code from rwsem.c to rwsem.h Waiman Long
2019-02-21 14:15 ` Will Deacon
2019-02-22 3:37 ` Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 03/10] locking/rwsem: Move rwsem internal function declarations to rwsem-xadd.h Waiman Long
2019-02-21 14:15 ` Will Deacon
2019-02-15 20:50 ` [PATCH-tip v2 04/10] locking/rwsem: Micro-optimize rwsem_try_read_lock_unqueued() Waiman Long
2019-02-21 14:15 ` Will Deacon [this message]
2019-02-15 20:50 ` [PATCH-tip v2 05/10] locking/rwsem: Add debug check for __down_read*() Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 06/10] locking/rwsem: Enhance DEBUG_RWSEMS_WARN_ON() macro Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 07/10] locking/qspinlock_stat: Introduce a generic lockevent counting APIs Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 08/10] locking/lock_events: Make lock_events available for all archs & other locks Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 09/10] locking/lock_events: Don't show pvqspinlock events on bare metal Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 10/10] locking/rwsem: Enable lock event counting Waiman Long
2019-02-26 18:20 ` [PATCH-tip v2 00/10] locking/rwsem: Rwsem rearchitecture part 1 Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221141514.GE12696@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave@stgolabs.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).