From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Pierre Morel <pmorel@linux.ibm.com>,
borntraeger@de.ibm.com, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, frankja@linux.ibm.com,
akrowiak@linux.ibm.com, david@redhat.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, freude@linux.ibm.com
Subject: Re: [PATCH v3 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem
Date: Thu, 21 Feb 2019 16:21:12 +0100 [thread overview]
Message-ID: <20190221162112.19d54f71@oc2783563651> (raw)
In-Reply-To: <20190221160910.5bf34f04.cohuck@redhat.com>
On Thu, 21 Feb 2019 16:09:10 +0100
Cornelia Huck <cohuck@redhat.com> wrote:
> On Thu, 21 Feb 2019 15:14:54 +0100
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
> > Libudev relies on having a subsystem link for non-root devices. To
> > avoid libudev (and potentially other userspace tools) choking on the
> > matrix device let us introduce a matrix bus and with it the matrix
> > bus subsytem. Also make the matrix device reside within the matrix
> > bus.
> >
> > Doing this we remove the forced link from the matrix device to the
> > vfio_ap driver and the device_type we do not need anymore.
> >
> > Since the associated matrix driver is not the vfio_ap driver any more,
> > we have to change the search for the devices on the vfio_ap driver in
> > the function vfio_ap_verify_queue_reserved.
> >
> > Fixes: 1fde573413b5 ("s390: vfio-ap: base implementation of VFIO AP device driver")
> >
> > Cc: stable@vger.kernel.org
> >
>
> I'd kill the two empty lines.
The summary/title line is a bit weird. It says link to the vfio_ap bus
subsystem, which sounds like establishing a relationship between two
pre-existing entities. But this change actually introduces the vfio_bus.
I would prefer something like "introduce vfio_ap bus".
I don't feel strongly about it.
Regards,
Halil
>
> > Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> > Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> > Acked-by: Halil Pasic <pasic@linux.ibm.com>
> > ---
> > drivers/s390/crypto/vfio_ap_drv.c | 44 ++++++++++++++++++++++++++++-------
> > drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
> > drivers/s390/crypto/vfio_ap_private.h | 1 +
> > 3 files changed, 38 insertions(+), 11 deletions(-)
>
> Otherwise, still looks good.
>
next prev parent reply other threads:[~2019-02-21 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 14:14 [PATCH v3 0/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem Pierre Morel
2019-02-21 14:14 ` [PATCH v3 1/1] " Pierre Morel
2019-02-21 15:09 ` Cornelia Huck
2019-02-21 15:21 ` Halil Pasic [this message]
2019-02-21 16:18 ` Tony Krowiak
2019-02-21 16:47 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221162112.19d54f71@oc2783563651 \
--to=pasic@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).