From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <shuahkhan@gmail.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Juerg Haefliger <juerg.haefliger@canonical.com>,
linux-kernel@vger.kernel.org, mingo@redhat.com,
Juerg Haefliger <juergh@canonical.com>
Subject: Re: [PATCH] selftests/ftrace: Handle the absence of tput
Date: Thu, 21 Feb 2019 19:24:37 -0500 [thread overview]
Message-ID: <20190221192437.2c2fe9f6@gandalf.local.home> (raw)
In-Reply-To: <20190222090534.12c57ef31518d2cb48670123@kernel.org>
On Fri, 22 Feb 2019 09:05:34 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> On Wed, 20 Feb 2019 16:37:06 +0100
> Juerg Haefliger <juerg.haefliger@canonical.com> wrote:
>
> > In environments where tput is not availbale, we get the following
> > error
> > $ ./ftracetest: 163: [: Illegal number:
> > because ncolors is an empty string. Fix that by setting it to 0 if the
> > tput command fails.
> >
> > Signed-off-by: Juerg Haefliger <juergh@canonical.com>
>
> Looks good to me.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Shuah,
Want to take this?
https://lore.kernel.org/lkml/20190220153706.24686-1-juergh@canonical.com/T/#u
-- Steve
>
> Thank you!
>
> > ---
> > tools/testing/selftests/ftrace/ftracetest | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> > index 75244db70331..fc755e1b50f1 100755
> > --- a/tools/testing/selftests/ftrace/ftracetest
> > +++ b/tools/testing/selftests/ftrace/ftracetest
> > @@ -154,13 +154,13 @@ fi
> >
> > # Define text colors
> > # Check available colors on the terminal, if any
> > -ncolors=`tput colors 2>/dev/null`
> > +ncolors=`tput colors 2>/dev/null || echo 0`
> > color_reset=
> > color_red=
> > color_green=
> > color_blue=
> > # If stdout exists and number of colors is eight or more, use them
> > -if [ -t 1 -a "$ncolors" -a "$ncolors" -ge 8 ]; then
> > +if [ -t 1 -a "$ncolors" -ge 8 ]; then
> > color_reset="\e[0m"
> > color_red="\e[31m"
> > color_green="\e[32m"
> > --
> > 2.19.1
> >
>
>
next prev parent reply other threads:[~2019-02-22 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 15:37 [PATCH] selftests/ftrace: Handle the absence of tput Juerg Haefliger
2019-02-20 19:47 ` Steven Rostedt
2019-02-22 0:05 ` Masami Hiramatsu
2019-02-22 0:24 ` Steven Rostedt [this message]
2019-02-25 13:14 ` [RESEND PATCH] " Juerg Haefliger
2019-02-25 14:51 ` shuah
2019-02-25 15:02 ` Juerg Haefliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221192437.2c2fe9f6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=juerg.haefliger@canonical.com \
--cc=juergh@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).