From: egranata@chromium.org To: gwendal@chromium.org, briannorris@chromium.org, hdegoede@redhat.com, mika.westerberg@linux.intel.com, dtor@chromium.org, andy.shevchenko@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, enric.balletbo@collabora.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, andriy.shevchenko@linux.intel.com Cc: egranata@google.com, Enrico Granata <egranata@chromium.org> Subject: [PATCH v3] driver: platform: Support parsing GpioInt 0 in platform_get_irq() Date: Thu, 21 Feb 2019 11:34:29 -0800 Message-ID: <20190221193429.161300-1-egranata@chromium.org> (raw) In-Reply-To: <20190220180538.GA42642@google.com> From: Enrico Granata <egranata@chromium.org> ACPI 5 added support for GpioInt resources as a way to provide information about interrupts mediated via a GPIO controller. Several device buses (e.g. SPI, I2C) have support for retrieving an IRQ specified via this type of resource, and providing it directly to the driver as an IRQ number. This is not currently done for the platform drivers, as platform_get_irq() does not try to parse GpioInt() resources. This requires drivers to either have to support only one possible IRQ resource, or to have code in place to try both as a failsafe. While there is a possibility of ambiguity for devices that exposes multiple IRQs, it is easy and feasible to support the common case of devices that only expose one IRQ which would be of either type depending on the underlying system's architecture. This commit adds support for parsing a GpioInt resource in order to fulfill a request for the index 0 IRQ for a platform device. Signed-off-by: Enrico Granata <egranata@chromium.org> --- Changes in v3: - ensured that -ENOENT return from acpi_dev_gpio_irq_get is not propagated upwards, as some drivers expect platform_get_irq to return either a valid IRQ or -ENXIO and will break otherwise drivers/base/platform.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 1c958eb33ef4d..afd8b916303e4 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -127,7 +127,24 @@ int platform_get_irq(struct platform_device *dev, unsigned int num) irqd_set_trigger_type(irqd, r->flags & IORESOURCE_BITS); } - return r ? r->start : -ENXIO; + if (r) + return r->start; + + /* + * For the index 0 interrupt, allow falling back to GpioInt + * resources. While a device could have both Interrupt and GpioInt + * resources, making this fallback ambiguous, in many common cases + * the device will only expose one IRQ, and this fallback + * allows a common code path across either kind of resource. + */ + if (num == 0 && has_acpi_companion(&dev->dev)) { + int ret = acpi_dev_gpio_irq_get(ACPI_COMPANION(&dev->dev), num); + + if (ret > 0 || ret == -EPROBE_DEFER) + return ret; + } + + return -ENXIO; #endif } EXPORT_SYMBOL_GPL(platform_get_irq); -- 2.21.0.rc0.258.g878e2cd30e-goog
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-07 18:59 [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq() egranata 2019-02-07 19:02 ` Rafael J. Wysocki 2019-02-07 19:39 ` Andy Shevchenko 2019-02-07 19:45 ` Andy Shevchenko 2019-02-07 19:55 ` Enrico Granata [not found] ` <CAPR809vnpuh8nOjU3QMCh6YJUKmtX92+bnHSUKGiAXAp6NwCHQ@mail.gmail.com> 2019-02-07 20:18 ` Andy Shevchenko 2019-02-07 20:29 ` Dmitry Torokhov 2019-02-11 10:30 ` Mika Westerberg 2019-02-11 15:42 ` Hans de Goede 2019-02-11 19:01 ` [PATCH v2] driver: platform: Support parsing GpioInt 0 in platform_get_irq() egranata 2019-02-11 19:25 ` Dmitry Torokhov 2019-02-12 7:29 ` Hans de Goede 2019-02-12 9:08 ` Mika Westerberg 2019-02-12 9:18 ` Rafael J. Wysocki 2019-02-12 12:46 ` Andy Shevchenko 2019-02-20 18:05 ` Brian Norris 2019-02-21 18:58 ` Enrico Granata 2019-02-21 19:34 ` egranata [this message] 2019-02-22 9:03 ` [PATCH v3] " Rafael J. Wysocki 2019-02-22 17:06 ` Brian Norris 2019-02-24 19:34 ` [PATCH v2] " Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190221193429.161300-1-egranata@chromium.org \ --to=egranata@chromium.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=andy.shevchenko@gmail.com \ --cc=briannorris@chromium.org \ --cc=dtor@chromium.org \ --cc=egranata@google.com \ --cc=enric.balletbo@collabora.com \ --cc=gregkh@linuxfoundation.org \ --cc=gwendal@chromium.org \ --cc=hdegoede@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=rafael@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git