From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62163C43381 for ; Sat, 23 Feb 2019 21:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ACB620665 for ; Sat, 23 Feb 2019 21:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FYiPrlAH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbfBWVjD (ORCPT ); Sat, 23 Feb 2019 16:39:03 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:45355 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbfBWVjD (ORCPT ); Sat, 23 Feb 2019 16:39:03 -0500 Received: by mail-pl1-f194.google.com with SMTP id r14so2679450pls.12; Sat, 23 Feb 2019 13:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zyXgafyQQfxp3wHOQiHpiJ/IXgmLY3NFW587N2PcJVs=; b=FYiPrlAHTENNU6Cbv34ztjLmFgvM9+3b8UgtrcJRWZyO3Esxjs0/JHO2c8NGvgPW8P 5gPI+p5R/ShHWdV5Y39HaKOQgNMScrY4EayUyR6nzkHWmsXhTjRjT74CQBYgQ+a3tRSQ TUytEAPcIuLcrVt2oNB6xltfpLiD1CiG+ycttZRdvcHPJ6ZkcMUj5ElHN4hCiHSfb1Do jpdwtwrOROpTJcgSwb+KvXNIDoSJObAlZzliAMMGzCFlkvLSBzQ87XACYxq+FNZN+Abs WNtSUuInUnIirFHUXczn8IX9OvZoUxx9fKMj7GbTG4t6m09KhygrOMUrFDpVeJp09a8S 7qzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zyXgafyQQfxp3wHOQiHpiJ/IXgmLY3NFW587N2PcJVs=; b=W0JmrC5o7MMe7Of4rbbNE0KURFZ6nEoxIitTMc/K5FplOHRy1cGeNTYNRHDp5HuJw5 ZCM+GJVEny0+GDCKB6lO78MXHuVBUbKBhdueLpK2tuu4Lxf+fEGMtarV/cfwMoYZsX7v 86Y6j9dcgWBPZbgUWPQYPFobiCAEbvZX9R0Om5dHWJnLfLFo45Nbdt9ILVKoBINCNZsn aAhAZpHy2ePv7YVex4QIDXAyWrfP/1eunzD2GX5w1eJRTvgNwIRmo9ZCf0K5BO8uSBOZ yQQKLe4tjR1JUtSXYYev+Z0Z8ylCgdPSiCl3HX2+4ooTmUB4nxBPveHv3NFczaUfXfrT ZCsQ== X-Gm-Message-State: AHQUAuZMb7ffGoycy2YRzvoGuOhzxpNxdYPxXzr2RZl/icI3EXhia+rt wHMgbRzbFLEM86j9cYuVJZc= X-Google-Smtp-Source: AHgI3IY3gA8lwthBaUcZZml4J9bUr/QrUkc4fl/6dhVINUdMhrmlMDlchB1JaYYE+4q/aHKNERAUGg== X-Received: by 2002:a17:902:5066:: with SMTP id f35mr10792137plh.184.1550957942199; Sat, 23 Feb 2019 13:39:02 -0800 (PST) Received: from localhost.localdomain ([2601:644:8201:32e0:7256:81ff:febd:926d]) by smtp.gmail.com with ESMTPSA id y19sm6708849pfm.181.2019.02.23.13.38.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Feb 2019 13:39:01 -0800 (PST) Date: Sat, 23 Feb 2019 13:38:59 -0800 From: Eduardo Valentin To: Anson Huang Cc: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "rui.zhang@intel.com" , "daniel.lezcano@linaro.org" , Aisheng Dong , "ulf.hansson@linaro.org" , "sboyd@kernel.org" , Daniel Baluta , Andy Gross , "horms+renesas@verge.net.au" , "heiko@sntech.de" , "arnd@arndb.de" , "maxime.ripard@bootlin.com" , "bjorn.andersson@linaro.org" , "jagan@amarulasolutions.com" , "enric.balletbo@collabora.com" , "marc.w.gonzalez@free.fr" , "olof@lixom.net" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V8 2/4] thermal: imx_sc: add i.MX system controller thermal support Message-ID: <20190223213858.GB1472@localhost.localdomain> References: <1550730831-14995-1-git-send-email-Anson.Huang@nxp.com> <1550730831-14995-2-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550730831-14995-2-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Anson, On Thu, Feb 21, 2019 at 06:38:39AM +0000, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and thermal sensors etc.. > > This patch adds i.MX system controller thermal driver support, > Linux kernel has to communicate with system controller via MU > (message unit) IPC to get each thermal sensor's temperature, > it supports multiple sensors which are passed from device tree, > please see the binding doc for details. > > Signed-off-by: Anson Huang > --- > Changes since V7: > - remove unused structure imx_sc_thermal_data to simply the driver; > - move the "imx,sensor-resource-id" property from thermal zone node to scu tsens node, and > get this property using phandle; > - remove unused sensor number got from dts, now it is not needed. > --- > drivers/thermal/Kconfig | 11 +++ > drivers/thermal/Makefile | 1 + > drivers/thermal/imx_sc_thermal.c | 144 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 156 insertions(+) > create mode 100644 drivers/thermal/imx_sc_thermal.c > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 58bb7d7..fec0ef5 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -223,6 +223,17 @@ config IMX_THERMAL > cpufreq is used as the cooling device to throttle CPUs when the > passive trip is crossed. > > +config IMX_SC_THERMAL > + tristate "Temperature sensor driver for NXP i.MX SoCs with System Controller" > + depends on (ARCH_MXC && IMX_SCU) || COMPILE_TEST > + depends on OF > + help > + Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with > + system controller inside, Linux kernel has to communicate with system > + controller via MU (message unit) IPC to get temperature from thermal > + sensor. It supports one critical trip point and one > + passive trip point for each thermal sensor. > + > config MAX77620_THERMAL > tristate "Temperature sensor driver for Maxim MAX77620 PMIC" > depends on MFD_MAX77620 > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > index 486d682..4062627 100644 > --- a/drivers/thermal/Makefile > +++ b/drivers/thermal/Makefile > @@ -40,6 +40,7 @@ obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o > obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o > obj-$(CONFIG_TANGO_THERMAL) += tango_thermal.o > obj-$(CONFIG_IMX_THERMAL) += imx_thermal.o > +obj-$(CONFIG_IMX_SC_THERMAL) += imx_sc_thermal.o > obj-$(CONFIG_MAX77620_THERMAL) += max77620_thermal.o > obj-$(CONFIG_QORIQ_THERMAL) += qoriq_thermal.o > obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o > diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c > new file mode 100644 > index 0000000..145e73b > --- /dev/null > +++ b/drivers/thermal/imx_sc_thermal.c > @@ -0,0 +1,144 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2018-2019 NXP. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "thermal_core.h" > + > +#define IMX_SC_MISC_FUNC_GET_TEMP 13 > +#define IMX_SC_C_TEMP 0 > + > +static struct imx_sc_ipc *thermal_ipc_handle; > + > +struct imx_sc_sensor { > + struct thermal_zone_device *tzd; > + u32 resource_id; > +}; > + > +struct req_get_temp { > + u16 resource_id; > + u8 type; > +} __packed; > + > +struct resp_get_temp { > + u16 celsius; > + u8 tenths; > +} __packed; > + > +struct imx_sc_msg_misc_get_temp { > + struct imx_sc_rpc_msg hdr; > + union { > + struct req_get_temp req; > + struct resp_get_temp resp; > + } data; > +} __packed; > + > +static int imx_sc_thermal_get_temp(void *data, int *temp) > +{ > + struct imx_sc_msg_misc_get_temp msg; > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > + struct imx_sc_sensor *sensor = data; > + int ret; > + > + msg.data.req.resource_id = sensor->resource_id; > + msg.data.req.type = IMX_SC_C_TEMP; > + > + hdr->ver = IMX_SC_RPC_VERSION; > + hdr->svc = IMX_SC_RPC_SVC_MISC; > + hdr->func = IMX_SC_MISC_FUNC_GET_TEMP; > + hdr->size = 2; > + > + ret = imx_scu_call_rpc(thermal_ipc_handle, &msg, true); > + if (ret) { > + pr_err("read temp sensor %d failed, ret %d\n", > + sensor->resource_id, ret); > + return ret; > + } > + > + *temp = msg.data.resp.celsius * 1000 + msg.data.resp.tenths * 100; > + > + return 0; > +} > + > +static const struct thermal_zone_of_device_ops imx_sc_thermal_ops = { > + .get_temp = imx_sc_thermal_get_temp, > +}; > + > +static int imx_sc_thermal_probe(struct platform_device *pdev) > +{ > + struct device_node *np, *sensor_np; > + int ret, i = 0; > + > + ret = imx_scu_get_handle(&thermal_ipc_handle); > + if (ret) > + return ret; > + > + np = of_find_node_by_name(NULL, "thermal-zones"); > + if (!np) > + return -ENODEV; I am still failing to understand why you need to do the search above and .. > + > + for_each_available_child_of_node(np, sensor_np) { > + struct of_phandle_args tsens_args; > + struct imx_sc_sensor *sensor = > + devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL); > + if (!sensor) > + return -ENOMEM; > + > + ret = of_parse_phandle_with_args(sensor_np, "thermal-sensors", > + "#thermal-sensor-cells", i, &tsens_args); the above shouldnt be needed too. > + if (ret < 0) > + return ret; > + > + ret = of_property_read_u32_index(tsens_args.np, > + "imx,sensor-resource-id", i, &sensor->resource_id); If you put "imx,sensor-resource-id" inside tsens node, like described in your patch 01, you should be able to get np from pdev->dev.of_node, right? Then you should be able to just read the "imx,sensor-resource-id" directly from pdev->dev.of_node, no? > + if (ret) { > + dev_err(&pdev->dev, > + "failed to get valid sensor resource id: %d\n", > + ret); > + break; > + } > + > + sensor->tzd = devm_thermal_zone_of_sensor_register(&pdev->dev, > + i++, > + sensor, > + &imx_sc_thermal_ops); > + if (IS_ERR(sensor->tzd)) { > + dev_err(&pdev->dev, "failed to register thermal zone\n"); > + ret = PTR_ERR(sensor->tzd); > + break; > + } > + } > + > + of_node_put(np); > + of_node_put(sensor_np); > + > + return ret; > +} > + > +static const struct of_device_id imx_sc_thermal_table[] = { > + { .compatible = "fsl,imx-sc-thermal", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, imx_sc_thermal_table); > + > +static struct platform_driver imx_sc_thermal_driver = { > + .probe = imx_sc_thermal_probe, > + .driver = { > + .name = "imx-sc-thermal", > + .of_match_table = imx_sc_thermal_table, > + }, > +}; > +module_platform_driver(imx_sc_thermal_driver); > + > +MODULE_AUTHOR("Anson Huang "); > +MODULE_DESCRIPTION("Thermal driver for NXP i.MX SoCs with system controller"); > +MODULE_LICENSE("GPL v2"); > -- > 2.7.4 >