From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCF0C43381 for ; Sun, 24 Feb 2019 13:51:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD88A20848 for ; Sun, 24 Feb 2019 13:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728334AbfBXNvg (ORCPT ); Sun, 24 Feb 2019 08:51:36 -0500 Received: from sauhun.de ([88.99.104.3]:35686 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726835AbfBXNvf (ORCPT ); Sun, 24 Feb 2019 08:51:35 -0500 Received: from localhost (pD95EF59B.dip0.t-ipconnect.de [217.94.245.155]) by pokefinder.org (Postfix) with ESMTPSA id B36602C28E9; Sun, 24 Feb 2019 14:51:33 +0100 (CET) Date: Sun, 24 Feb 2019 14:51:33 +0100 From: Wolfram Sang To: Jim Broadus Cc: ckeepax@opensource.cirrus.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires Subject: Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device. Message-ID: <20190224135133.GC1245@kunai> References: <20190219193027.13882-1-jbroadus@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dkEUBIird37B8yKS" Content-Disposition: inline In-Reply-To: <20190219193027.13882-1-jbroadus@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dkEUBIird37B8yKS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote: > A previous change allowed I2C client devices to discover new IRQs upon > reprobe by clearing the IRQ in i2c_device_remove. However, if an IRQ was > assigned in i2c_new_device, that information is lost. >=20 > For example, the touchscreen and trackpad devices on a Dell Inspiron lapt= op > are I2C devices whose IRQs are defined by ACPI extended IRQ types. The > client device structures are initialized during an ACPI walk. After > removing the i2c_hid device, modprobe fails. >=20 > This change caches the initial IRQ value in i2c_new_device and then resets > the client device IRQ to the initial value in i2c_device_remove. >=20 > Fixes: 6f108dd70d30 ("i2c: Clear client->irq in i2c_device_remove") > Signed-off-by: Jim Broadus Applied to for-next, thanks! I didn't want to apply to for-current because I didn't feel comfortable changing the I2C core in this very last days before the release. It will hit linus tree during next merge window and go back to older releases via stable. That all being said, I'd really love to see the proper fix (move irq assignment from init to probe time) being worked on rather soonish before we forget all the details we know at this moment. I'll be there for it. --dkEUBIird37B8yKS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlxyoWQACgkQFA3kzBSg Kbazgg//bM6XAh0HokHCQRRLpv3rOJLsay9p6F2gRVw6scYR1QbpZG03nPtzOm/S UAgXONZIHCaorIqpn/XLv5fFjzGtQExl0hR9iRd8hwnwflAVdkdAYbdTq1+J4hYx Rs6nMmkUYZOpPbl9XonGz7rfm5kijmUt4A9Y4lY3J/mMQvBgKGsDz5ro4YQQQADv KVJd+FggH7qr9bbRp97WDJGcS94H6po8nU9pvSRc1bMXzYjmusNO8dkAn90RQZb7 XKfCxaKrt077rAvYMJGYp7Q1rCbvuLvB007bOQ6D4R1lby6oDZtWwad0XWAmSp36 bMqFriFWKA0a1SbaAnBaSo6F7d196ASb8c70bPsyqyntf/Z7hvfjqwIBzEJowbzE SNFLwGTmHQH0tAJFomXH1ampmwUZyiA9MRsGbEpOsjYBVhQu07x/YqrWQv+nTnoF NEx9aQ/3d2297EA9eGPZFoFXNzeUuRVUswYhA6HnIwfBLJ8f6h7zus4wjQhFvR0H l7M8ieAn+CrZNbgwErbmG5iFwdJumsJTB+zlwiaDSioxJEWj0pPNfX7Z5z/zIwjV jlr+esoyUtwBX4nDCohWc/qhhRcIw+RVCIzQbNaVPlHTBmSzQ269Kw61nhPAcsIB MJOx6YJP6A/xnko/XQuBYJPbn1mm1vzSout2wJq06SuwmJietKQ= =cEYW -----END PGP SIGNATURE----- --dkEUBIird37B8yKS--