From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84C8C10F00 for ; Mon, 25 Feb 2019 10:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5D8E2087C for ; Mon, 25 Feb 2019 10:13:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="BTwZiacn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfBYKNS (ORCPT ); Mon, 25 Feb 2019 05:13:18 -0500 Received: from mail.skyhub.de ([5.9.137.197]:41176 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbfBYKNR (ORCPT ); Mon, 25 Feb 2019 05:13:17 -0500 Received: from zn.tnic (p200300EC2BC6800089D86D6F51D98E14.dip0.t-ipconnect.de [IPv6:2003:ec:2bc6:8000:89d8:6d6f:51d9:8e14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 190CB1EC0253; Mon, 25 Feb 2019 11:13:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1551089595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=XfVvh50wOD3SHp1PjeV74AHOn9WwC9KJOSZ4O87FpzU=; b=BTwZiacn7l0DOtxhBuyD6A68Qyut47L7eiyCfkShFPRC6t56IQFsbsIZuE3/HQRkqs5YBe D6BUtCgMQ20lV8k/43ITYZjWN1UyZP9SMBtCCHuuPN/CAAI4jpvtvlzx7msUg7N8ISMcjw ctXv3vkiM1Hj8vbSBtT6wLqcRc4adzE= Date: Mon, 25 Feb 2019 11:13:07 +0100 From: Borislav Petkov To: Jiri Slaby Cc: mingo@redhat.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v7 07/28] x86/asm/crypto: annotate local functions Message-ID: <20190225101307.GD26145@zn.tnic> References: <20190130124711.12463-1-jslaby@suse.cz> <20190130124711.12463-8-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190130124711.12463-8-jslaby@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 30, 2019 at 01:46:50PM +0100, Jiri Slaby wrote: > Use the newly added SYM_FUNC_START_LOCAL to annotate starts of all > functions which do not have ".globl" annotation, but their ends are > annotated by ENDPROC. This is needed to balance ENDPROC for tools that > generate debuginfo. > > To be symmetric, we also convert their ENDPROCs to the new SYM_FUNC_END. > > Signed-off-by: Jiri Slaby > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: > Cc: > --- > arch/x86/crypto/aegis128-aesni-asm.S | 8 ++-- > arch/x86/crypto/aegis128l-aesni-asm.S | 8 ++-- > arch/x86/crypto/aegis256-aesni-asm.S | 8 ++-- > arch/x86/crypto/aesni-intel_asm.S | 49 ++++++++------------ > arch/x86/crypto/camellia-aesni-avx-asm_64.S | 20 ++++---- > arch/x86/crypto/camellia-aesni-avx2-asm_64.S | 20 ++++---- > arch/x86/crypto/cast5-avx-x86_64-asm_64.S | 8 ++-- > arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 8 ++-- > arch/x86/crypto/chacha-ssse3-x86_64.S | 4 +- > arch/x86/crypto/ghash-clmulni-intel_asm.S | 4 +- > arch/x86/crypto/morus1280-avx2-asm.S | 16 +++---- > arch/x86/crypto/morus1280-sse2-asm.S | 16 +++---- > arch/x86/crypto/morus640-sse2-asm.S | 16 +++---- > arch/x86/crypto/serpent-avx-x86_64-asm_64.S | 8 ++-- > arch/x86/crypto/serpent-avx2-asm_64.S | 8 ++-- > arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 8 ++-- > 16 files changed, 100 insertions(+), 109 deletions(-) > > diff --git a/arch/x86/crypto/aegis128-aesni-asm.S b/arch/x86/crypto/aegis128-aesni-asm.S > index 5f7e43d4f64a..87b94664296a 100644 > --- a/arch/x86/crypto/aegis128-aesni-asm.S > +++ b/arch/x86/crypto/aegis128-aesni-asm.S > @@ -74,7 +74,7 @@ > * %r8 > * %r9 > */ > -__load_partial: > +SYM_FUNC_START_LOCAL(__load_partial) Btw, here's what I mean with it being problematic when the global symbol names are not distinctive enough: arch/x86/crypto/aegis128-aesni-asm.S:77:SYM_FUNC_START_LOCAL(__load_partial) arch/x86/crypto/aegis128l-aesni-asm.S:68:SYM_FUNC_START_LOCAL(__load_partial) arch/x86/crypto/aegis256-aesni-asm.S:61:SYM_FUNC_START_LOCAL(__load_partial) arch/x86/crypto/morus1280-avx2-asm.S:115:SYM_FUNC_START_LOCAL(__load_partial) arch/x86/crypto/morus1280-sse2-asm.S:237:SYM_FUNC_START_LOCAL(__load_partial) arch/x86/crypto/morus640-sse2-asm.S:115:SYM_FUNC_START_LOCAL(__load_partial) There are a bunch of those __{load,store}_partial labels and staring at traces with them in it does not really help, unless you know which one is it. Should not be addressed by your patchset but those should be local labels... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.