From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, jolsa@kernel.org,
namhyung@kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 07/11] perf tools report: Support running scripts for current time range
Date: Mon, 25 Feb 2019 13:56:35 +0100 [thread overview]
Message-ID: <20190225125635.GL19795@krava> (raw)
In-Reply-To: <20190224153722.27020-8-andi@firstfloor.org>
On Sun, Feb 24, 2019 at 07:37:18AM -0800, Andi Kleen wrote:
SNIP
> + endtime += 1*1000000;
> + }
> + timestamp__scnprintf_usec(starttime, start, sizeof start);
> + timestamp__scnprintf_usec(endtime, end, sizeof end);
> + n += snprintf(script_opt + n, len - n, " --time %s,%s", start, end);
> + }
> +
> script_browse(script_opt);
> + free(script_opt);
> return 0;
> }
>
> static int
> -add_script_opt(struct hist_browser *browser __maybe_unused,
> +add_script_opt_2(struct hist_browser *browser __maybe_unused,
> struct popup_action *act, char **optstr,
> - struct thread *thread, struct symbol *sym)
> + struct thread *thread, struct symbol *sym,
> + const char *tstr)
> {
> +
> if (thread) {
> - if (asprintf(optstr, "Run scripts for samples of thread [%s]",
> - thread__comm_str(thread)) < 0)
> + if (asprintf(optstr, "Run scripts for samples of thread [%s]%s",
> + thread__comm_str(thread), tstr) < 0)
> return 0;
> } else if (sym) {
> - if (asprintf(optstr, "Run scripts for samples of symbol [%s]",
> - sym->name) < 0)
> + if (asprintf(optstr, "Run scripts for samples of symbol [%s]%s",
> + sym->name, tstr) < 0)
> return 0;
> } else {
> - if (asprintf(optstr, "Run scripts for all samples") < 0)
> + if (asprintf(optstr, "Run scripts for all samples%s", tstr) < 0)
> return 0;
can't see the time ranges in the menu.. what's the path
to get them listed?
thanks,
jirka
next prev parent reply other threads:[~2019-02-25 12:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 15:37 Support sample context in perf report Andi Kleen
2019-02-24 15:37 ` [PATCH 01/11] perf tools script: Handle missing fields with -F + Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:49 ` Arnaldo Carvalho de Melo
2019-02-28 8:04 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2019-02-24 15:37 ` [PATCH 02/11] perf tools script: Support insn output for normal samples Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 03/11] perf tools report: Support nano seconds Andi Kleen
2019-02-25 16:40 ` Sebastien Boisvert
2019-02-25 17:34 ` Andi Kleen
2019-02-24 15:37 ` [PATCH 04/11] perf tools report: Parse time quantum Andi Kleen
2019-02-25 12:55 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 05/11] perf tools report: Support time sort key Andi Kleen
2019-02-24 15:37 ` [PATCH 06/11] perf tools report: Use less for scripts output Andi Kleen
2019-02-25 12:55 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 07/11] perf tools report: Support running scripts for current time range Andi Kleen
2019-02-25 12:55 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa [this message]
2019-02-25 13:28 ` Andi Kleen
2019-02-25 13:35 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 08/11] perf tools: Add perf_exe() helper to find perf binary Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:58 ` Arnaldo Carvalho de Melo
2019-02-28 8:05 ` [tip:perf/core] " tip-bot for Andi Kleen
2019-02-24 15:37 ` [PATCH 09/11] perf tools report: Support builtin perf script in scripts menu Andi Kleen
2019-02-25 12:57 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 10/11] perf tools: Add utility function to print ns time stamps Andi Kleen
2019-02-24 15:37 ` [PATCH 11/11] perf tools report: Implement browsing of individual samples Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:33 ` Andi Kleen
2019-03-04 14:48 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:31 ` Andi Kleen
2019-02-25 13:35 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225125635.GL19795@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).