From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Tony Jones <tonyj@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>,
Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH 04/15] perf script python: add Python3 support to failed-syscalls-by-pid.py
Date: Mon, 25 Feb 2019 11:09:06 -0300 [thread overview]
Message-ID: <20190225140906.GG31136@kernel.org> (raw)
In-Reply-To: <20190222230619.17887-5-tonyj@suse.de>
Em Fri, Feb 22, 2019 at 03:06:08PM -0800, Tony Jones escreveu:
> Support both Python2 and Python3 in the failed-syscalls-by-pid.py script
>
> There may be differences in the ordering of output lines due to
> differences in dictionary ordering etc. However the format within lines
> should be unchanged.
>
> The use of 'from __future__' implies the minimum supported Python2 version
> is now v2.6
Applied
> Signed-off-by: Tony Jones <tonyj@suse.de>
> Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
> Cc: Tom Zanussi <tzanussi@gmail.com>
> ---
> .../scripts/python/failed-syscalls-by-pid.py | 21 ++++++++++---------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/tools/perf/scripts/python/failed-syscalls-by-pid.py b/tools/perf/scripts/python/failed-syscalls-by-pid.py
> index cafeff3d74db..3648e8b986ec 100644
> --- a/tools/perf/scripts/python/failed-syscalls-by-pid.py
> +++ b/tools/perf/scripts/python/failed-syscalls-by-pid.py
> @@ -5,6 +5,8 @@
> # Displays system-wide failed system call totals, broken down by pid.
> # If a [comm] arg is specified, only syscalls called by [comm] are displayed.
>
> +from __future__ import print_function
> +
> import os
> import sys
>
> @@ -32,7 +34,7 @@ if len(sys.argv) > 1:
> syscalls = autodict()
>
> def trace_begin():
> - print "Press control+C to stop and show the summary"
> + print("Press control+C to stop and show the summary")
>
> def trace_end():
> print_error_totals()
> @@ -57,22 +59,21 @@ def syscalls__sys_exit(event_name, context, common_cpu,
>
> def print_error_totals():
> if for_comm is not None:
> - print "\nsyscall errors for %s:\n\n" % (for_comm),
> + print("\nsyscall errors for %s:\n" % (for_comm))
> else:
> - print "\nsyscall errors:\n\n",
> + print("\nsyscall errors:\n")
>
> - print "%-30s %10s\n" % ("comm [pid]", "count"),
> - print "%-30s %10s\n" % ("------------------------------", \
> - "----------"),
> + print("%-30s %10s" % ("comm [pid]", "count"))
> + print("%-30s %10s" % ("------------------------------", "----------"))
>
> comm_keys = syscalls.keys()
> for comm in comm_keys:
> pid_keys = syscalls[comm].keys()
> for pid in pid_keys:
> - print "\n%s [%d]\n" % (comm, pid),
> + print("\n%s [%d]" % (comm, pid))
> id_keys = syscalls[comm][pid].keys()
> for id in id_keys:
> - print " syscall: %-16s\n" % syscall_name(id),
> + print(" syscall: %-16s" % syscall_name(id))
> ret_keys = syscalls[comm][pid][id].keys()
> - for ret, val in sorted(syscalls[comm][pid][id].iteritems(), key = lambda(k, v): (v, k), reverse = True):
> - print " err = %-20s %10d\n" % (strerror(ret), val),
> + for ret, val in sorted(syscalls[comm][pid][id].items(), key = lambda kv: (kv[1], kv[0]), reverse = True):
> + print(" err = %-20s %10d" % (strerror(ret), val))
> --
> 2.20.1
--
- Arnaldo
next prev parent reply other threads:[~2019-02-25 14:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 23:06 [PATCH 00/15] perf script python: add Python3 support Tony Jones
2019-02-22 23:06 ` [PATCH 01/15] perf script python: add Python3 support to netdev-times.py Tony Jones
2019-02-28 8:06 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 02/15] perf script python: add Python3 support to check-perf-trace.py Tony Jones
2019-02-25 14:05 ` Arnaldo Carvalho de Melo
2019-02-25 18:05 ` Tony Jones
2019-02-22 23:06 ` [PATCH 03/15] perf script python: add Python3 support to event_analyzing_sample.py Tony Jones
2019-02-25 14:08 ` Arnaldo Carvalho de Melo
2019-02-22 23:06 ` [PATCH 04/15] perf script python: add Python3 support to failed-syscalls-by-pid.py Tony Jones
2019-02-25 14:09 ` Arnaldo Carvalho de Melo [this message]
2019-02-28 8:06 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 05/15] perf script python: add Python3 support to futex-contention.py Tony Jones
2019-02-22 23:06 ` [PATCH 06/15] perf script python: add Python3 support to intel-pt-events.py Tony Jones
2019-02-25 7:07 ` Adrian Hunter
2019-02-25 14:03 ` Arnaldo Carvalho de Melo
2019-02-25 17:18 ` Tony Jones
2019-02-22 23:06 ` [PATCH 07/15] perf script python: add Python3 support to mem-phys-addr.py Tony Jones
2019-02-28 8:07 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 08/15] perf script python: add Python3 support to net_dropmonitor.py Tony Jones
2019-02-25 12:37 ` Neil Horman
2019-02-25 14:43 ` Arnaldo Carvalho de Melo
2019-02-28 8:08 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 09/15] perf script python: add Python3 support to powerpc-hcalls.py Tony Jones
2019-02-25 14:44 ` Arnaldo Carvalho de Melo
2019-02-28 8:08 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 10/15] perf script python: add Python3 support to sctop.py Tony Jones
2019-02-25 14:44 ` Arnaldo Carvalho de Melo
2019-02-28 8:09 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 11/15] perf script python: add Python3 support to stackcollapse.py Tony Jones
2019-02-25 14:46 ` Arnaldo Carvalho de Melo
2019-02-28 8:09 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 12/15] perf script python: add Python3 support to stat-cpi.py Tony Jones
2019-02-25 14:46 ` Arnaldo Carvalho de Melo
2019-02-28 8:10 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 13/15] perf script python: add Python3 support to syscall-counts.py Tony Jones
2019-02-25 14:47 ` Arnaldo Carvalho de Melo
2019-02-28 8:11 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 14/15] perf script python: add Python3 support to syscall-counts-by-pid.py Tony Jones
2019-02-25 14:48 ` Arnaldo Carvalho de Melo
2019-02-28 8:11 ` [tip:perf/core] perf script python: Add " tip-bot for Tony Jones
2019-02-22 23:06 ` [PATCH 15/15] perf script python: add Python3 support to sql scripts Tony Jones
2019-02-25 14:51 ` Arnaldo Carvalho de Melo
2019-02-25 14:54 ` Arnaldo Carvalho de Melo
2019-02-25 17:20 ` Tony Jones
2019-02-23 21:06 ` [PATCH 00/15] perf script python: add Python3 support Tony Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225140906.GG31136@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=s1seetee@linux.vnet.ibm.com \
--cc=tonyj@suse.de \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).