From: Jiri Olsa <jolsa@redhat.com>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 1/3] perf diff: Support --time filter option
Date: Mon, 25 Feb 2019 15:19:23 +0100 [thread overview]
Message-ID: <20190225141923.GF14757@krava> (raw)
In-Reply-To: <3aeba79c-b729-6c89-6ef3-22a565653d73@linux.intel.com>
On Mon, Feb 25, 2019 at 10:12:08PM +0800, Jin, Yao wrote:
>
>
> On 2/25/2019 9:38 PM, Jiri Olsa wrote:
> > On Mon, Feb 25, 2019 at 09:42:42PM +0800, Jin Yao wrote:
> >
> > SNIP
> >
> > > COMPARISON
> > > ----------
> > > The comparison is governed by the baseline file. The baseline perf.data
> > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> > > index 751e197..ddc41e7 100644
> > > --- a/tools/perf/builtin-diff.c
> > > +++ b/tools/perf/builtin-diff.c
> > > @@ -19,12 +19,21 @@
> > > #include "util/util.h"
> > > #include "util/data.h"
> > > #include "util/config.h"
> > > +#include "util/time-utils.h"
> > > #include <errno.h>
> > > #include <inttypes.h>
> > > #include <stdlib.h>
> > > #include <math.h>
> > > +struct perf_diff {
> > > + struct perf_tool tool;
> > > + const char *time_str;
> > > + struct perf_time_interval *ptime_range;
> > > + int range_size;
> > > + int range_num;
> >
> > please align the members
> >
>
> Not aligned? Sorry, could you give me an example?
one extra tab before the name:
struct perf_tool tool;
const char *time_str;
struct perf_time_interval *ptime_range;
int range_size;
int range_num;
jirka
next prev parent reply other threads:[~2019-02-25 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 13:42 [PATCH v1 0/3] perf diff: Add new filter options Jin Yao
2019-02-25 13:42 ` [PATCH v1 1/3] perf diff: Support --time filter option Jin Yao
2019-02-25 13:38 ` Jiri Olsa
2019-02-25 14:12 ` Jin, Yao
2019-02-25 14:19 ` Jiri Olsa [this message]
2019-02-25 14:54 ` Jin, Yao
2019-02-25 13:42 ` [PATCH v1 2/3] perf diff: Support --cpu " Jin Yao
2019-02-25 13:42 ` [PATCH v1 3/3] perf diff: Support --pid/--tid filter options Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225141923.GF14757@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).