From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36876C43381 for ; Mon, 25 Feb 2019 21:27:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04233213A2 for ; Mon, 25 Feb 2019 21:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551130037; bh=b3jmMqw73fDijZ5r8P0ckLk2v+GipD2D8BUQyAO4luI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=e0Tb9oh8XICfVzespfRmePXkOAlST7ktYhOIoFHUdBnfDitSVyRHvQKMvso+c/Wzs pyTCOnsbD4PWiIPlIgdjQVx/1/o6ImE+XkvA5kNAZZiBV6nlcSW6tKBqWWWL9u/U2q b8HBDIgPcJ7ikVlpoSbwrFkZKXAfT00Guzr2UPCQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731697AbfBYV1O (ORCPT ); Mon, 25 Feb 2019 16:27:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:33212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730296AbfBYV1M (ORCPT ); Mon, 25 Feb 2019 16:27:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF1FB2146F; Mon, 25 Feb 2019 21:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551130032; bh=b3jmMqw73fDijZ5r8P0ckLk2v+GipD2D8BUQyAO4luI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wz6sxY74c+LNvFi+yEl0e6/dIZI8H+Ini0SqVEX84Y+NqHEEiZ/u+K7Z25oTGRfsd plhKSGM7Wi6bOzFD/F3wUmyFAp6JN1qvobingfLx9quK9bzeZwPZd44HHS8kEoBDXQ WZNPFswUIb8w9wYcUXvnXN4P8C+A0gxXfN3zBRLc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Al Viro , Gao Xiang Subject: [PATCH 4.19 138/152] staging: erofs: remove the redundant d_rehash() for the root dentry Date: Mon, 25 Feb 2019 22:12:10 +0100 Message-Id: <20190225195053.449091960@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195043.645958524@linuxfoundation.org> References: <20190225195043.645958524@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gao Xiang commit e9c892465583c8f42d61fafe30970d36580925df upstream. There is actually no need at all to d_rehash() for the root dentry as Al pointed out, fix it. Reported-by: Al Viro Cc: Al Viro Signed-off-by: Gao Xiang Signed-off-by: Greg Kroah-Hartman --- drivers/staging/erofs/super.c | 6 ------ 1 file changed, 6 deletions(-) --- a/drivers/staging/erofs/super.c +++ b/drivers/staging/erofs/super.c @@ -404,12 +404,6 @@ static int erofs_read_super(struct super erofs_register_super(sb); - /* - * We already have a positive dentry, which was instantiated - * by d_make_root. Just need to d_rehash it. - */ - d_rehash(sb->s_root); - if (!silent) infoln("mounted on %s with opts: %s.", dev_name, (char *)data);