From: Borislav Petkov <bp@alien8.de>
To: Baoquan He <bhe@redhat.com>, Kees Cook <keescook@chromium.org>
Cc: Pingfan Liu <kernelfans@gmail.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Will Deacon <will.deacon@arm.com>,
Nicolas Pitre <nico@linaro.org>,
Chao Fan <fanc.fnst@cn.fujitsu.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region
Date: Wed, 27 Feb 2019 08:39:58 +0100 [thread overview]
Message-ID: <20190227073958.GA1786@zn.tnic> (raw)
In-Reply-To: <20190227013034.GP14858@MiWiFi-R3L-srv>
+ Kees.
@Kees, you might want to go upthread a bit for context.
On Wed, Feb 27, 2019 at 09:30:34AM +0800, Baoquan He wrote:
> Agree that 'crashkernel=x' should be encouraged to use as the first
> choice when reserve crashkernel. If we decide to not obsolete
> 'crashkernel=x@y', it will leave a unstable kernel parameter.
Is anyone even talking about obsoleting this?
And if anyone is, anyone can think a bit why we can't do this.
> Another worry is that KASLR won't always fail 'crashkernel=x@y',
> customer may set and check in testing stage, then later in production
> environment one time of neglect to not check may cause carashed kernel
> uncaptured.
>
> IMHO, 'crashkernel=x@y' is similar to those specified memmap=ss[#$!]nn
> which have been avoided in boot stage KASLR.
So my worry is that by specifying too many exclusion ranges, we might
limit the kaslr space too much and make it too predictable. Especially
since distros slap those things automatically and most users take them
for granted.
But I might be way off here because of something else I'm missing ...
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-02-27 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 7:59 [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region Pingfan Liu
2019-02-25 8:23 ` Chao Fan
2019-02-26 3:11 ` Pingfan Liu
2019-02-25 9:45 ` Borislav Petkov
2019-02-25 13:05 ` Baoquan He
2019-02-26 5:11 ` Dave Young
2019-02-26 3:08 ` Pingfan Liu
2019-02-26 10:46 ` Borislav Petkov
2019-02-27 1:30 ` Baoquan He
2019-02-27 7:39 ` Borislav Petkov [this message]
2019-03-06 7:58 ` Pingfan Liu
2019-03-11 2:49 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227073958.GA1786@zn.tnic \
--to=bp@alien8.de \
--cc=ard.biesheuvel@linaro.org \
--cc=bhe@redhat.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kernelfans@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nico@linaro.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).