From: Jiri Olsa <jolsa@redhat.com>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 1/3] perf diff: Support --time filter option
Date: Wed, 27 Feb 2019 14:10:45 +0100 [thread overview]
Message-ID: <20190227131045.GB18893@krava> (raw)
In-Reply-To: <2eecb3cf-1dcc-f98f-1ca5-f9c29bd8fd8f@linux.intel.com>
On Wed, Feb 27, 2019 at 08:51:44PM +0800, Jin, Yao wrote:
>
>
> On 2/27/2019 5:28 PM, Jiri Olsa wrote:
> > On Tue, Feb 26, 2019 at 08:11:07PM +0800, Jin Yao wrote:
> >
> > SNIP
> >
> > > + .ordered_events = true,
> > > + .ordering_requires_timestamps = true,
> > > + },
> > > };
> > > static struct perf_evsel *evsel_match(struct perf_evsel *evsel,
> > > @@ -771,19 +788,136 @@ static void data__free(struct data__file *d)
> > > }
> > > }
> > > +static int parse_time_range(struct data__file *d,
> > > + struct perf_time_interval *ptime_range,
> > > + const char *time_str)
> > > +{
> > > + if (perf_time__parse_str(ptime_range,
> > > + time_str) != 0) {
> > > + if (d->session->evlist->first_sample_time == 0 &&
> > > + d->session->evlist->last_sample_time == 0) {
> > > + pr_err("HINT: no first/last sample time found in perf data.\n"
> > > + "Please use latest perf binary to execute 'perf record'\n"
> > > + "(if '--buildid-all' is enabled, please set '--timestamp-boundary').\n");
> > > + return -EINVAL;
> > > + }
> > > +
> > > + pdiff.range_num = perf_time__percent_parse_str(
> > > + ptime_range, pdiff.range_size, time_str,
> > > + d->session->evlist->first_sample_time,
> > > + d->session->evlist->last_sample_time);
> > > +
> > > + if (pdiff.range_num < 0) {
> > > + pr_err("Invalid time string\n");
> > > + return -EINVAL;
> > > + }
> > > + } else {
> > > + pdiff.range_num = 1;
> >
> > I dont understand why we set range_num to 1 if there's
> > not time option set.. it should be 0 and we should take
> > no action in diff__process_sample_event, right?
> >
> > then I checked the report code and we do the same,
> > could we fix that? I'm assuming we don't need any
> > time check if the time option is not set.. please
> > correct me if I miss something
> >
> > jirka
> >
>
> We support multiple complicated time strings. :(
>
> In parse_time_range(), perf_time__parse_str() returns 0 if the time string
> is a simple start/stop format. So next, we set the range_num to 1. If the
> time string contains multiple time percent ranges (e.g. "10%/1,10%/2,..."),
> perf_time__parse_str() will return with error (<0), then we will continue
> checking with perf_time__percent_parse_str().
>
> So when range_num is set to 1, it just means it's the simple time string.
why do we need to have time range set if there's no --time
option set by user?
jirka
next prev parent reply other threads:[~2019-02-27 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 12:11 [PATCH v2 0/3] perf diff: Add new filter options Jin Yao
2019-02-26 12:11 ` [PATCH v2 1/3] perf diff: Support --time filter option Jin Yao
2019-02-27 9:27 ` Jiri Olsa
2019-02-27 13:04 ` Jin, Yao
2019-02-27 13:25 ` Jiri Olsa
2019-02-27 9:28 ` Jiri Olsa
2019-02-27 12:51 ` Jin, Yao
2019-02-27 13:10 ` Jiri Olsa [this message]
2019-02-27 14:24 ` Jin, Yao
2019-02-26 12:11 ` [PATCH v2 2/3] perf diff: Support --cpu " Jin Yao
2019-02-26 12:11 ` [PATCH v2 3/3] perf diff: Support --pid/--tid filter options Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227131045.GB18893@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).