From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, hughd@google.com,
kirill@shutemov.name, vbabka@suse.cz, joel@joelfernandes.org,
jglisse@redhat.com, yang.shi@linux.alibaba.com,
mgorman@techsingularity.net
Subject: Re: [PATCH] mm,mremap: Bail out earlier in mremap_to under map pressure
Date: Wed, 27 Feb 2019 22:32:09 +0100 [thread overview]
Message-ID: <20190227213205.5wdjucqdgfqx33tr@d104.suse.de> (raw)
In-Reply-To: <20190226140428.3e7c8188eda6a54f9da08c43@linux-foundation.org>
On Tue, Feb 26, 2019 at 02:04:28PM -0800, Andrew Morton wrote:
> How is this going to affect existing userspace which is aware of the
> current behaviour?
Well, current behavior is not really predictable.
Our customer was "surprised" that the call to mremap() failed, but the regions
got unmapped nevertheless.
They found it the hard way when they got a segfault when trying to write to those
regions when cleaning up.
As I said in the changelog, the possibility for false positives exists, due to
the fact that we might get rid of several vma's when unmapping, but I do not
expect existing userspace applications to start failing.
Should be that the case, we can revert the patch, it is not that it adds a lot
of churn.
> And how does it affect your existing cleanup code, come to that? Does
> it work as well or better after this change?
I guess the customer can trust more reliable that the maps were left untouched.
I still have my reserves though.
We can get as far as move_vma(), and copy_vma() can fail returning -ENOMEM.
(Or not due to the "too small to fail" ?)
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-02-27 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 9:13 [PATCH] mm,mremap: Bail out earlier in mremap_to under map pressure Oscar Salvador
2019-02-26 22:04 ` Andrew Morton
2019-02-27 21:32 ` Oscar Salvador [this message]
2019-02-28 8:06 ` Vlastimil Babka
2019-02-28 20:44 ` Joel Fernandes
2019-03-01 15:25 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227213205.5wdjucqdgfqx33tr@d104.suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=joel@joelfernandes.org \
--cc=kirill@shutemov.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).