From: Rob Herring <robh@kernel.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"edubezval@gmail.com" <edubezval@gmail.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Andy Gross <andy.gross@linaro.org>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
"heiko@sntech.de" <heiko@sntech.de>,
"arnd@arndb.de" <arnd@arndb.de>,
"maxime.ripard@bootlin.com" <maxime.ripard@bootlin.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
"olof@lixom.net" <olof@lixom.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding
Date: Wed, 27 Feb 2019 17:54:55 -0600 [thread overview]
Message-ID: <20190227235455.GA15211@bogus> (raw)
In-Reply-To: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com>
On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote:
> NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
> system controller, the system controller is in charge of system
> power, clock and thermal sensors etc. management, Linux kernel
> has to communicate with system controller via MU (message unit)
> IPC to get temperature from thermal sensors, this patch adds
> binding doc for i.MX system controller thermal driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V9:
> - change #thermal-sensor-cells value in example to 1, since there are other
> thermal sensors inside system controller, it is just because there are still
> some issue, so system controller does NOT expose them for now, they could
> be exposed later, so it should be 1 from HW perspective.
> ---
> .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 72d481c..855270b 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol
> Required properties:
> - compatible: should be "fsl,imx8qxp-sc-rtc";
>
> +Thermal bindings based on SCU Message Protocol
> +------------------------------------------------------------
> +
> +Required properties:
> +- compatible: Should be :
> + "fsl,imx8qxp-sc-thermal"
> + followed by "fsl,imx-sc-thermal";
> +
> +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt
> + for a description.
> +
> +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or
> + an array of integers to specify each thermal zone's sensor
> + resource ID.
Can't you put the resource ids in the thermal-sensor cells? Why do you
need to list them here?
Rob
next prev parent reply other threads:[~2019-02-27 23:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 8:46 [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding Anson Huang
2019-02-27 8:46 ` [PATCH V10 2/4] thermal: imx_sc: add i.MX system controller thermal support Anson Huang
2019-02-27 8:46 ` [PATCH V10 3/4] defconfig: arm64: " Anson Huang
2019-02-27 8:46 ` [PATCH V10 4/4] arm64: dts: imx: add i.MX8QXP " Anson Huang
2019-02-27 23:54 ` Rob Herring [this message]
2019-02-28 0:47 ` [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding Anson Huang
2019-02-28 14:49 ` Rob Herring
2019-03-01 1:41 ` Anson Huang
2019-03-06 5:27 ` Anson Huang
2019-03-13 8:12 ` Anson Huang
2019-03-26 2:44 ` Anson Huang
2019-04-09 5:28 ` Anson Huang
2019-04-09 7:28 ` Zhang Rui
2019-04-10 6:05 ` [EXT] " Anson Huang
2019-04-10 7:44 ` Anson Huang
2019-03-06 14:40 ` Aisheng Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227235455.GA15211@bogus \
--to=robh@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=andy.gross@linaro.org \
--cc=anson.huang@nxp.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=olof@lixom.net \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).