From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE24C43381 for ; Thu, 28 Feb 2019 11:37:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2241214D8 for ; Thu, 28 Feb 2019 11:37:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732573AbfB1LhJ (ORCPT ); Thu, 28 Feb 2019 06:37:09 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45734 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730883AbfB1LhJ (ORCPT ); Thu, 28 Feb 2019 06:37:09 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1SBY0kF048277 for ; Thu, 28 Feb 2019 06:37:07 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qxdejmfmt-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 28 Feb 2019 06:37:07 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 28 Feb 2019 11:37:04 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 28 Feb 2019 11:36:57 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x1SBav1G61407436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Feb 2019 11:36:57 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8BD64C046; Thu, 28 Feb 2019 11:36:56 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 61E7D4C040; Thu, 28 Feb 2019 11:36:55 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.8.84]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 28 Feb 2019 11:36:55 +0000 (GMT) Date: Thu, 28 Feb 2019 13:36:53 +0200 From: Mike Rapoport To: Geert Uytterhoeven Cc: Steven Price , Linux MM , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?iso-8859-1?B?Suly9G1l?= Glisse , Peter Zijlstra , Thomas Gleixner , Will Deacon , the arch/x86 maintainers , "H. Peter Anvin" , Linux ARM , Linux Kernel Mailing List , Mark Rutland , "Liang, Kan" , linux-m68k Subject: Re: [PATCH v3 09/34] m68k: mm: Add p?d_large() definitions References: <20190227170608.27963-1-steven.price@arm.com> <20190227170608.27963-10-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19022811-0008-0000-0000-000002C5FFBF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19022811-0009-0000-0000-0000223250FB Message-Id: <20190228113653.GB3766@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-28_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902280081 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: > Hi Steven, > > On Wed, Feb 27, 2019 at 6:07 PM Steven Price wrote: > > walk_page_range() is going to be allowed to walk page tables other than > > those of user space. For this it needs to know when it has reached a > > 'leaf' entry in the page tables. This information is provided by the > > p?d_large() functions/macros. > > > > For m68k, we don't support large pages, so add stubs returning 0 > > > > CC: Geert Uytterhoeven > > CC: linux-m68k@lists.linux-m68k.org > > Signed-off-by: Steven Price > > Thanks for your patch! > > > arch/m68k/include/asm/mcf_pgtable.h | 2 ++ > > arch/m68k/include/asm/motorola_pgtable.h | 2 ++ > > arch/m68k/include/asm/pgtable_no.h | 1 + > > arch/m68k/include/asm/sun3_pgtable.h | 2 ++ > > 4 files changed, 7 insertions(+) > > If the definitions are the same, why not add them to > arch/m68k/include/asm/pgtable.h instead? Maybe I'm missing something, but why the stubs have to be defined in arch/*/include/asm/pgtable.h rather than in include/asm-generic/pgtable.h? > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- Sincerely yours, Mike.