From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Jonathan Corbet <corbet@lwn.net>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] doc: rcu: Suspicious RCU usage is a warning
Date: Thu, 28 Feb 2019 08:51:43 -0800 [thread overview]
Message-ID: <20190228165143.GU4072@linux.ibm.com> (raw)
In-Reply-To: <20190228105932.1274-1-geert+renesas@glider.be>
On Thu, Feb 28, 2019 at 11:59:32AM +0100, Geert Uytterhoeven wrote:
> Suspicious RCU usage messages are reported as warnings.
>
> Fixes: a5dd63efda3d07b5 ("lockdep: Use "WARNING" tag on lockdep splats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
> ---
> And before that, they were printed as errors, which was also never
> reflected in the documentation...
> ---
> Documentation/RCU/lockdep-splat.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/RCU/lockdep-splat.txt b/Documentation/RCU/lockdep-splat.txt
> index 9423b633526d14df..9c015976b174123f 100644
> --- a/Documentation/RCU/lockdep-splat.txt
> +++ b/Documentation/RCU/lockdep-splat.txt
> @@ -14,9 +14,9 @@ being the real world and all that.
> So let's look at an example RCU lockdep splat from 3.0-rc5, one that
> has long since been fixed:
>
> -===============================
> -[ INFO: suspicious RCU usage. ]
> --------------------------------
> +=============================
> +WARNING: suspicious RCU usage
> +-----------------------------
> block/cfq-iosched.c:2776 suspicious rcu_dereference_protected() usage!
>
> other info that might help us debug this:
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-02-28 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 10:59 [PATCH] doc: rcu: Suspicious RCU usage is a warning Geert Uytterhoeven
2019-02-28 16:51 ` Paul E. McKenney [this message]
2019-03-04 19:53 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228165143.GU4072@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).