From: Rob Herring <robh@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
mark.rutland@arm.com, orsonzhai@gmail.com, zhang.lyra@gmail.com,
broonie@kernel.org, lanqing.liu@unisoc.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: serial: sprd: Add dma properties to support DMA mode
Date: Thu, 28 Feb 2019 13:53:19 -0600 [thread overview]
Message-ID: <20190228195319.GA13133@bogus> (raw)
In-Reply-To: <8f0a032f9bcce28bb0d147f9646950f64fc22a74.1550560916.git.baolin.wang@linaro.org>
On Tue, Feb 19, 2019 at 03:31:14PM +0800, Baolin Wang wrote:
> From: Lanqing Liu <lanqing.liu@unisoc.com>
>
> This patch adds dmas and dma-names properties for the UART DMA mode.
>
> Signed-off-by: Lanqing Liu <lanqing.liu@unisoc.com>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> .../devicetree/bindings/serial/sprd-uart.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> index 6eb5863..9ac28f6 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> @@ -15,12 +15,18 @@ Required properties:
> UART clock and source clock are optional properties, but enable clock
> is required.
>
> +Optional properties:
> +- dma-names: Should contain "tx" for transmit and "rx" for receive channels.
The order here doesn't match the example.
> +- dmas: A list of dma specifiers, one for each entry in dma-names.
> +
> Example:
> uart0: serial@0 {
> compatible = "sprd,sc9860-uart",
> "sprd,sc9836-uart";
> reg = <0x0 0x100>;
> interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> + dma-names = "rx", "tx";
> + dmas = <&ap_dma 19 19>, <&ap_dma 20 20>;
> clock-names = "enable", "uart", "source";
> clocks = <&clk_ap_apb_gates 9>, <&clk_uart0>, <&ext_26m>;
> };
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2019-02-28 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 7:31 [PATCH 0/5] Add new features for the Spreadtrum serial controller Baolin Wang
2019-02-19 7:31 ` [PATCH 1/5] serial: sprd: Modify the baud rate calculation formula Baolin Wang
2019-02-19 7:31 ` [PATCH 2/5] dt-bindings: serial: sprd: Add clocks and clocks-names properties Baolin Wang
2019-02-28 19:52 ` Rob Herring
2019-02-19 7:31 ` [PATCH 3/5] serial: sprd: Add power management for the Spreadtrum serial controller Baolin Wang
2019-02-19 7:31 ` [PATCH 4/5] dt-bindings: serial: sprd: Add dma properties to support DMA mode Baolin Wang
2019-02-28 19:53 ` Rob Herring [this message]
2019-03-01 9:42 ` Baolin Wang
2019-02-19 7:31 ` [PATCH 5/5] serial: sprd: Add DMA mode support Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228195319.GA13133@bogus \
--to=robh@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=lanqing.liu@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).