From: Greg KH <gregkh@linuxfoundation.org>
To: Parav Pandit <parav@mellanox.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.lkml@markovi.net, davem@davemloft.net, jiri@mellanox.com
Subject: Re: [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices
Date: Fri, 1 Mar 2019 08:21:58 +0100 [thread overview]
Message-ID: <20190301072158.GC8975@kroah.com> (raw)
In-Reply-To: <1551418672-12822-9-git-send-email-parav@mellanox.com>
On Thu, Feb 28, 2019 at 11:37:52PM -0600, Parav Pandit wrote:
> Add a subdev driver to probe the subdev devices and create fake
> netdevice for it.
So I'm guessing here is the "meat" of the whole goal here?
You just want multiple netdevices per PCI device? Why can't you do that
today in your PCI driver?
What problem are you trying to solve that others also are having that
requires all of this?
Adding a new bus type and subsystem is fine, but usually we want more
than just one user of it, as this does not really show how it is
exercised very well. Ideally 3 users would be there as that is when it
proves itself that it is flexible enough.
Would just using the mfd subsystem work better for you? That provides
core support for "multi-function" drivers/devices already. What is
missing from that subsystem that does not work for you here?
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-01 7:22 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 5:37 [RFC net-next 0/8] Introducing subdev bus and devlink extension Parav Pandit
2019-03-01 5:37 ` [RFC net-next 1/8] subdev: Introducing subdev bus Parav Pandit
2019-03-01 7:17 ` Greg KH
2019-03-01 16:35 ` Parav Pandit
2019-03-01 17:00 ` Greg KH
2019-03-26 11:48 ` Lorenzo Pieralisi
2019-03-01 5:37 ` [RFC net-next 2/8] subdev: Introduce pm callbacks Parav Pandit
2019-03-01 5:37 ` [RFC net-next 3/8] modpost: Add support for subdev device id table Parav Pandit
2019-03-01 5:37 ` [RFC net-next 4/8] devlink: Introduce and use devlink_init/cleanup() in alloc/free Parav Pandit
2019-03-01 5:37 ` [RFC net-next 5/8] devlink: Add variant of devlink_register/unregister Parav Pandit
2019-03-01 5:37 ` [RFC net-next 6/8] devlink: Add support for devlink subdev lifecycle Parav Pandit
2019-03-01 5:37 ` [RFC net-next 7/8] net/mlx5: Add devlink subdev life cycle command support Parav Pandit
2019-03-01 7:18 ` Greg KH
2019-03-01 16:04 ` Parav Pandit
2019-03-01 5:37 ` [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices Parav Pandit
2019-03-01 7:21 ` Greg KH [this message]
2019-03-01 17:21 ` Parav Pandit
2019-03-05 7:13 ` Greg KH
2019-03-05 17:57 ` Parav Pandit
2019-03-05 19:27 ` Greg KH
2019-03-05 21:37 ` Parav Pandit
2019-03-01 22:12 ` Saeed Mahameed
2019-03-04 16:45 ` Parav Pandit
2019-03-01 20:03 ` [RFC net-next 0/8] Introducing subdev bus and devlink extension Jakub Kicinski
2019-03-04 4:41 ` Parav Pandit
2019-03-05 1:35 ` Jakub Kicinski
2019-03-05 19:46 ` Parav Pandit
2019-03-05 22:39 ` Kirti Wankhede
2019-03-05 23:17 ` Parav Pandit
2019-03-05 23:44 ` Parav Pandit
2019-03-06 0:44 ` Parav Pandit
2019-03-06 3:51 ` Kirti Wankhede
2019-03-06 5:42 ` Parav Pandit
2019-03-07 19:04 ` Kirti Wankhede
2019-03-07 20:27 ` Parav Pandit
2019-03-07 20:53 ` Kirti Wankhede
2019-03-07 21:02 ` Parav Pandit
2019-03-07 21:07 ` Kirti Wankhede
2019-03-07 21:21 ` Parav Pandit
2019-03-07 22:01 ` Kirti Wankhede
2019-03-07 22:31 ` Parav Pandit
2019-03-08 12:19 ` Kirti Wankhede
2019-03-08 17:09 ` Parav Pandit
2019-03-05 1:45 ` Jakub Kicinski
2019-03-05 16:52 ` Parav Pandit
2021-05-31 10:36 ` moyufeng
2021-06-01 5:37 ` Jakub Kicinski
2021-06-01 7:33 ` Yunsheng Lin
2021-06-01 21:34 ` Jakub Kicinski
2021-06-02 2:24 ` Yunsheng Lin
2021-06-02 16:34 ` Jakub Kicinski
2021-06-03 3:46 ` Yunsheng Lin
2021-06-03 17:53 ` Jakub Kicinski
2021-06-04 1:18 ` Yunsheng Lin
2021-06-04 18:41 ` Jakub Kicinski
2021-06-07 1:36 ` Yunsheng Lin
2021-06-07 19:46 ` Jakub Kicinski
2021-06-08 12:10 ` Yunsheng Lin
2021-06-08 17:29 ` Jakub Kicinski
2021-06-09 9:16 ` Yunsheng Lin
2021-06-09 9:38 ` Parav Pandit
2021-06-09 11:05 ` Yunsheng Lin
2021-06-09 11:59 ` Parav Pandit
2021-06-09 12:30 ` Yunsheng Lin
2021-06-09 13:45 ` Parav Pandit
2021-06-10 7:04 ` Yunsheng Lin
2021-06-10 7:17 ` Parav Pandit
2021-06-09 16:40 ` Jakub Kicinski
2021-06-10 6:52 ` Yunsheng Lin
2021-06-09 9:52 ` Parav Pandit
2021-06-09 11:16 ` Yunsheng Lin
2021-06-09 12:00 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301072158.GC8975@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).