From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] perf/core: Mark expected switch fall-through
Date: Fri, 1 Mar 2019 10:53:44 -0300 [thread overview]
Message-ID: <20190301135344.GG13100@kernel.org> (raw)
In-Reply-To: <2c4e0c7b-1166-387e-fe39-6b4ee5c32c7d@embeddedor.com>
Em Thu, Feb 28, 2019 at 03:31:31PM -0600, Gustavo A. R. Silva escreveu:
> Hi all,
>
> Friendly ping:
>
> Who can ack or review this, please?
I'm applying it, thanks.
- Arnaldo
> Thanks
> --
> Gustavo
>
> On 2/12/19 2:54 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > cases where we are expecting to fall through.
> >
> > This patch fixes the following warning:
> >
> > kernel/events/core.c: In function ‘perf_event_parse_addr_filter’:
> > kernel/events/core.c:9154:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > kernel = 1;
> > ~~~~~~~^~~
> > kernel/events/core.c:9156:3: note: here
> > case IF_SRC_FILEADDR:
> > ^~~~
> >
> > Warning level 3 was used: -Wimplicit-fallthrough=3
> >
> > This patch is part of the ongoing efforts to enable
> > -Wimplicit-fallthrough.
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > ---
> > kernel/events/core.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index ac194d3aae32..343ee21ab958 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -9152,6 +9152,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
> > case IF_SRC_KERNELADDR:
> > case IF_SRC_KERNEL:
> > kernel = 1;
> > + /* fall through */
> >
> > case IF_SRC_FILEADDR:
> > case IF_SRC_FILE:
> >
--
- Arnaldo
next prev parent reply other threads:[~2019-03-01 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 20:54 [PATCH] perf/core: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-28 21:31 ` Gustavo A. R. Silva
2019-03-01 13:53 ` Arnaldo Carvalho de Melo [this message]
2019-03-01 15:50 ` Gustavo A. R. Silva
2019-03-09 14:40 ` [tip:perf/urgent] " tip-bot for Gustavo A. R. Silva
2019-03-09 19:48 ` [tip:perf/urgent] perf: " tip-bot for Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301135344.GG13100@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=gustavo@embeddedor.com \
--cc=jolsa@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).