From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Feng Tang <feng.tang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@suse.de>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH v5] panic: Avoid the extra noise dmesg
Date: Fri, 1 Mar 2019 14:29:39 -0500 [thread overview]
Message-ID: <20190301142939.072e6a26@gandalf.local.home> (raw)
In-Reply-To: <20190301085401.vmfnw4geqz5xyeeh@pathway.suse.cz>
On Fri, 1 Mar 2019 09:54:01 +0100
Petr Mladek <pmladek@suse.com> wrote:
I'll put my $0.02 in, and say I like the idea of the patch too.
> > > Thoughts:
> > >
> > > - why do the suppression in vprintk_emit()? Doing it right at entry
> > > to printk() seems cleaner, more explicit?
> >
> > Yes, I put it in printk() in one earlier post, and Petr suggested to
> > put it into vprintk_emit so that it works for all printk() interfaces,
> > like the devkmsg_write -> printk_emit -> vprintk_emit path.
>
> Yes, there are more printk interfaces. The check in vprintk_emit()
> allows to calm down also prink_deferred() and dev_printk().
Agreed.
>
> > > - Other code sites may wish to suppress all printks. Perhaps
> > > `panic_suppress_printk' should just be called `suppress_printk'?
> > Ok, then I'll move the definition from panic.c to printk code.
>
> This change looks fine to me.
>
> Best Regards,
> Petr
>
> PS: I am sorry for the late review. I have spent many days with
> reviewing a proposal of rewrite of printk() internals.
Thanks for doing that, BTW.
-- Steve
prev parent reply other threads:[~2019-03-01 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 6:00 [PATCH v5] panic: Avoid the extra noise dmesg Feng Tang
2019-02-22 6:09 ` Feng Tang
2019-02-28 20:00 ` Andrew Morton
2019-03-01 4:11 ` Feng Tang
2019-03-01 8:54 ` Petr Mladek
2019-03-01 19:29 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301142939.072e6a26@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=feng.tang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).